From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-la0-f54.google.com ([209.85.215.54]:36675 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbbFEN2H (ORCPT ); Fri, 5 Jun 2015 09:28:07 -0400 Received: by laar3 with SMTP id r3so5186683laa.3 for ; Fri, 05 Jun 2015 06:28:04 -0700 (PDT) Message-ID: <5571A3E3.6070805@cogentembedded.com> Date: Fri, 05 Jun 2015 16:28:03 +0300 From: Sergei Shtylyov MIME-Version: 1.0 To: Hans Verkuil , linux-media@vger.kernel.org CC: linux-sh@vger.kernel.org, Hans Verkuil Subject: Re: [PATCH 07/10] sh-vou: add support for log_status References: <1433501966-30176-1-git-send-email-hverkuil@xs4all.nl> <1433501966-30176-8-git-send-email-hverkuil@xs4all.nl> In-Reply-To: <1433501966-30176-8-git-send-email-hverkuil@xs4all.nl> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello. On 6/5/2015 1:59 PM, Hans Verkuil wrote: > From: Hans Verkuil > Dump the VOU registers in log_status. > Signed-off-by: Hans Verkuil > --- > drivers/media/platform/sh_vou.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c > index 7ed5a8b..400efec 100644 > --- a/drivers/media/platform/sh_vou.c > +++ b/drivers/media/platform/sh_vou.c > @@ -951,6 +951,34 @@ static int sh_vou_g_std(struct file *file, void *priv, v4l2_std_id *std) > return 0; > } > > +static int sh_vou_log_status(struct file *file, void *priv) > +{ > + struct sh_vou_device *vou_dev = video_drvdata(file); > + > + pr_info("PSELA: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUER)); > + pr_info("VOUER: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUER)); You're dumping the same register twice, under different names? > + pr_info("VOUCR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUCR)); > + pr_info("VOUSTR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUSTR)); > + pr_info("VOUVCR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUVCR)); > + pr_info("VOUISR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUISR)); > + pr_info("VOUBCR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUBCR)); > + pr_info("VOUDPR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUDPR)); > + pr_info("VOUDSR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUDSR)); > + pr_info("VOUVPR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUVPR)); > + pr_info("VOUIR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUIR)); > + pr_info("VOUSRR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUSRR)); > + pr_info("VOUMSR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUMSR)); > + pr_info("VOUHIR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUHIR)); > + pr_info("VOUDFR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUDFR)); > + pr_info("VOUAD1R: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUAD1R)); > + pr_info("VOUAD2R: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUAD2R)); > + pr_info("VOUAIR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUAIR)); > + pr_info("VOUSWR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOUSWR)); > + pr_info("VOURCR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOURCR)); > + pr_info("VOURPR: 0x%08x\n", sh_vou_reg_a_read(vou_dev, VOURPR)); > + return 0; > +} > + [...] WBR, Sergei