Re: [PATCH][media] SI2168: Resolve unknown chip version errors with different HVR22x5 models

[Antti Palosaari <crope@iki.fi>]

On 06/05/2015 04:40 PM, Olli Salonen wrote:
> Hi Steven,
>
> It seems to me that that part of the code is identical to your driver, no?
>
> The media_tree driver:
>
> retval = saa7164_api_i2c_read(bus,
>                       msgs[i].addr,
>                       0 /* reglen */,
>                       NULL /* reg */, msgs[i].len, msgs[i].buf);
>
> It's exactly the same with a little bit different formatting.

And that looks correct.

But the patch which does not look correct, or is at least unclear, is that
[media] saa7164: Improvements for I2C handling
http://permalink.gmane.org/gmane.comp.video.linuxtv.scm/22211

First change does not have any effect as len should be zero in any case 
and memcpy() should do nothing.

Second change looks something that is likely wrong. There is some hack 
which increases data len. All that register len stuff is logically wrong 
- I2C adapter handles just bytes and should not know nothing about 
client register layout. OK, there is some exceptions (like af9035) where 
I2C firmware actually knows register layout for some strange reason.

So could you remove that patch and test?

Antti

-- 
http://palosaari.fi/