From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Cc: dale.hamel@srvthe.net, michael@stegemann.it
Subject: Re: [PATCH v2 0/2] stk1160: Frame scaling and "de-verbosification"
Date: Mon, 08 Jun 2015 12:28:15 -0300 [thread overview]
Message-ID: <5575B48F.5070208@vanguardiasur.com.ar> (raw)
In-Reply-To: <5575682E.3000209@xs4all.nl>
On 06/08/2015 07:02 AM, Hans Verkuil wrote:
> Hi Ezequiel,
>
> On 06/07/2015 12:26 AM, Ezequiel Garcia wrote:
>> I've removed the driver verbosity and fixed the frame scale implementation.
>> In addition to the usual mplayer/vlc/qv4l2, it's tested with v4l2-compliance
>> on 4.1-rc4.
>
> I recommend you use the media_tree.git master branch: v4l2-compliance is always
> in sync with that one.
>
> I'm not getting the issues you show below with v4l2-compliance -s (although once
> it starts streaming I get sequence errors, see the patch I posted that fixes that).
>
> So use the media_tree master branch and use the latest v4l2-compliance. If you still
> get the error you see below, then that needs to be investigated further, since I
> don't see it.
>
> However, testing with v4l2-compliance -f (which tests scaling) just stalls:
>
> Test input 0:
>
> Stream using all formats:
> test MMAP for Format UYVY, Frame Size 6x4:
>
> It sits there until I press Ctrl-C.
>
> This is NTSC input, BTW.
>
Ouch, sorry about that. I'll re-run with latest v4l2-compliance.
You've marked the "stk1160: Reduce driver verbosity" also as
changes-requested. Do you want any changes on it? I don't think that
patch can introduce any issues, since it's just fixing the level of printks.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2015-06-08 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 22:26 [PATCH v2 0/2] stk1160: Frame scaling and "de-verbosification" Ezequiel Garcia
2015-06-06 22:26 ` [PATCH v2 1/2] stk1160: Reduce driver verbosity Ezequiel Garcia
2015-06-06 22:26 ` [PATCH v2 2/2] stk1160: Add frame scaling support Ezequiel Garcia
2015-06-08 10:02 ` [PATCH v2 0/2] stk1160: Frame scaling and "de-verbosification" Hans Verkuil
2015-06-08 15:28 ` Ezequiel Garcia [this message]
2015-06-08 16:35 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5575B48F.5070208@vanguardiasur.com.ar \
--to=ezequiel@vanguardiasur.com.ar \
--cc=dale.hamel@srvthe.net \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=michael@stegemann.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox