Re: [PATCH v2 0/2] stk1160: Frame scaling and "de-verbosification"

[Hans Verkuil <hverkuil@xs4all.nl>]

On 06/08/2015 05:28 PM, Ezequiel Garcia wrote:
> 
> 
> On 06/08/2015 07:02 AM, Hans Verkuil wrote:
>> Hi Ezequiel,
>>
>> On 06/07/2015 12:26 AM, Ezequiel Garcia wrote:
>>> I've removed the driver verbosity and fixed the frame scale implementation.
>>> In addition to the usual mplayer/vlc/qv4l2, it's tested with v4l2-compliance
>>> on 4.1-rc4.
>>
>> I recommend you use the media_tree.git master branch: v4l2-compliance is always
>> in sync with that one.
>>
>> I'm not getting the issues you show below with v4l2-compliance -s (although once
>> it starts streaming I get sequence errors, see the patch I posted that fixes that).
>>
>> So use the media_tree master branch and use the latest v4l2-compliance. If you still
>> get the error you see below, then that needs to be investigated further, since I
>> don't see it.
>>
>> However, testing with v4l2-compliance -f (which tests scaling) just stalls:
>>
>> Test input 0:
>>
>> Stream using all formats:
>>         test MMAP for Format UYVY, Frame Size 6x4:
>>
>> It sits there until I press Ctrl-C.
>>
>> This is NTSC input, BTW.
>>
> 
> Ouch, sorry about that. I'll re-run with latest v4l2-compliance.
> 
> You've marked the "stk1160: Reduce driver verbosity" also as
> changes-requested. Do you want any changes on it? I don't think that
> patch can introduce any issues, since it's just fixing the level of printks.
> 

No, that one is OK. I expect you'll repost the patch series anyway.

Regards,

	Hans