From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:36530 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbbFHQfb (ORCPT ); Mon, 8 Jun 2015 12:35:31 -0400 Message-ID: <5575C44B.5010601@xs4all.nl> Date: Mon, 08 Jun 2015 18:35:23 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Ezequiel Garcia , linux-media@vger.kernel.org CC: dale.hamel@srvthe.net, michael@stegemann.it Subject: Re: [PATCH v2 0/2] stk1160: Frame scaling and "de-verbosification" References: <1433629618-1833-1-git-send-email-ezequiel@vanguardiasur.com.ar> <5575682E.3000209@xs4all.nl> <5575B48F.5070208@vanguardiasur.com.ar> In-Reply-To: <5575B48F.5070208@vanguardiasur.com.ar> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 06/08/2015 05:28 PM, Ezequiel Garcia wrote: > > > On 06/08/2015 07:02 AM, Hans Verkuil wrote: >> Hi Ezequiel, >> >> On 06/07/2015 12:26 AM, Ezequiel Garcia wrote: >>> I've removed the driver verbosity and fixed the frame scale implementation. >>> In addition to the usual mplayer/vlc/qv4l2, it's tested with v4l2-compliance >>> on 4.1-rc4. >> >> I recommend you use the media_tree.git master branch: v4l2-compliance is always >> in sync with that one. >> >> I'm not getting the issues you show below with v4l2-compliance -s (although once >> it starts streaming I get sequence errors, see the patch I posted that fixes that). >> >> So use the media_tree master branch and use the latest v4l2-compliance. If you still >> get the error you see below, then that needs to be investigated further, since I >> don't see it. >> >> However, testing with v4l2-compliance -f (which tests scaling) just stalls: >> >> Test input 0: >> >> Stream using all formats: >> test MMAP for Format UYVY, Frame Size 6x4: >> >> It sits there until I press Ctrl-C. >> >> This is NTSC input, BTW. >> > > Ouch, sorry about that. I'll re-run with latest v4l2-compliance. > > You've marked the "stk1160: Reduce driver verbosity" also as > changes-requested. Do you want any changes on it? I don't think that > patch can introduce any issues, since it's just fixing the level of printks. > No, that one is OK. I expect you'll repost the patch series anyway. Regards, Hans