From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: florian.vaussard@epfl.ch
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: Regression inside omap3isp/resizer (was: 3fdfeda causes a regression)
Date: Tue, 31 Dec 2013 09:51:57 +0100 [thread overview]
Message-ID: <5578156.0MrbcJaUWJ@avalon> (raw)
In-Reply-To: <52B8AF81.3040804@epfl.ch>
Hi Florian,
Sorry for the late reply.
On Monday 23 December 2013 22:47:45 Florian Vaussard wrote:
> On 12/17/2013 11:42 AM, Florian Vaussard wrote:
> > Hello Laurent,
> >
> > I was working on having a functional IOMMU/ISP for 3.14, and had an
> > issue with an image completely distorted. Comparing with another kernel,
> > I saw that PRV_HORZ_INFO and PRV_VERT_INFO differed. On the newer
> > kernel, sph, eph, svl, and slv were all off-by 2, causing my final image
> > to miss 4 pixels on each line, thus distorting the result.
> >
> > Your commit 3fdfedaaa7f243f3347084231c64f6c1be0ba131 '[media] omap3isp:
> > preview: Lower the crop margins' indeed changes PRV_HORZ_INFO and
> > PRV_VERT_INFO by removing the if() condition. Reverting it made my image
> > to be valid again.
> >
> > FYI, my pipeline is:
> >
> > MT9V032 (SGRBG10 752x480) -> CCDC -> PREVIEW (UYVY 752x480) -> RESIZER
> > -> out
>
> Just an XMAS ping on this :-) Do you have any idea how to solve this
> without reverting the patch?
The patch indeed changed the preview engine margins, but the change is
supposed to be handled by applications. As a base for this discussion could
you please provide the media-ctl -p output before and after applying the patch
? You can strip the unrelated media entities out of the output.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-12-31 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 10:42 3fdfedaaa7f243f3347084231c64f6c1be0ba131 causes a regression Florian Vaussard
2013-12-23 21:47 ` Regression inside omap3isp/resizer (was: 3fdfeda causes a regression) Florian Vaussard
2013-12-31 8:51 ` Laurent Pinchart [this message]
2014-01-09 18:09 ` Regression inside omap3isp/resizer Florian Vaussard
2014-01-09 20:34 ` Laurent Pinchart
2014-01-09 20:45 ` Florian Vaussard
2014-01-09 20:50 ` Laurent Pinchart
2014-01-17 7:15 ` Sakari Ailus
2014-01-17 14:45 ` Florian Vaussard
2014-01-17 18:15 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5578156.0MrbcJaUWJ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=florian.vaussard@epfl.ch \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox