From: Hans Verkuil <hverkuil@xs4all.nl>
To: William Towle <william.towle@codethink.co.uk>,
linux-media@vger.kernel.org, linux-kernel@lists.codethink.co.uk
Cc: guennadi liakhovetski <g.liakhovetski@gmx.de>,
sergei shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 15/15] media: rcar_vin: Reject videobufs that are too small for current format
Date: Fri, 12 Jun 2015 11:22:48 +0200 [thread overview]
Message-ID: <557AA4E8.40208@xs4all.nl> (raw)
In-Reply-To: <1433340002-1691-16-git-send-email-william.towle@codethink.co.uk>
On 06/03/2015 04:00 PM, William Towle wrote:
> From: Rob Taylor <rob.taylor@codethink.co.uk>
>
> In videobuf_setup reject buffers that are too small for the configured
> format. Fixes v4l2-complience issue.
>
> Signed-off-by: Rob Taylor <rob.taylor@codethink.co.uk>
> Reviewed-by: William Towle <william.towle@codethink.co.uk>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Thanks,
Hans
> ---
> drivers/media/platform/soc_camera/rcar_vin.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index cc993bc..1531a76 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -541,6 +541,9 @@ static int rcar_vin_videobuf_setup(struct vb2_queue *vq,
> unsigned int bytes_per_line;
> int ret;
>
> + if (fmt->fmt.pix.sizeimage < icd->sizeimage)
> + return -EINVAL;
> +
> xlate = soc_camera_xlate_by_fourcc(icd,
> fmt->fmt.pix.pixelformat);
> if (!xlate)
>
next prev parent reply other threads:[~2015-06-12 9:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 13:59 HDMI and Composite capture on Lager, for kernel 4.1, version 3 William Towle
2015-06-03 13:59 ` [PATCH 01/15] ARM: shmobile: lager dts: Add entries for VIN HDMI input support William Towle
2015-06-03 13:59 ` [PATCH 02/15] media: soc_camera: rcar_vin: Add BT.709 24-bit RGB888 " William Towle
2015-06-12 6:31 ` Hans Verkuil
2015-06-03 13:59 ` [PATCH 03/15] media: adv7180: add of match table William Towle
2015-06-12 6:31 ` Hans Verkuil
2015-06-03 13:59 ` [PATCH 04/15] media: adv7604: chip info and formats for ADV7612 William Towle
2015-06-12 6:27 ` Hans Verkuil
2015-06-03 13:59 ` [PATCH 05/15] media: adv7604: document support for ADV7612 dual HDMI input decoder William Towle
2015-06-12 6:29 ` Hans Verkuil
2015-06-03 13:59 ` [PATCH 06/15] media: adv7604: ability to read default input port from DT William Towle
2015-06-12 6:29 ` Hans Verkuil
2015-06-03 13:59 ` [PATCH 07/15] ARM: shmobile: lager dts: specify default-input for ADV7612 William Towle
2015-06-03 13:59 ` [PATCH 08/15] v4l: subdev: Add pad config allocator and init William Towle
2015-06-03 13:59 ` [PATCH 09/15] media: soc_camera pad-aware driver initialisation William Towle
2015-06-12 9:15 ` Hans Verkuil
2015-06-14 9:40 ` Guennadi Liakhovetski
2015-06-03 13:59 ` [PATCH 10/15] media: rcar_vin: Use correct pad number in try_fmt William Towle
2015-06-12 9:17 ` Hans Verkuil
2015-06-20 10:59 ` Guennadi Liakhovetski
2015-06-03 13:59 ` [PATCH 11/15] media: soc_camera: soc_scale_crop: " William Towle
2015-06-12 9:18 ` Hans Verkuil
2015-06-20 11:38 ` Guennadi Liakhovetski
2015-06-20 11:45 ` Guennadi Liakhovetski
2015-06-03 13:59 ` [PATCH 12/15] media: soc_camera: Fill std field in enum_input William Towle
2015-06-03 14:00 ` [PATCH 13/15] media: soc_camera: Fix error reporting in expbuf William Towle
2015-06-03 14:00 ` [PATCH 14/15] media: soc_camera: fill in bus_info field William Towle
2015-06-12 9:22 ` Hans Verkuil
2015-06-03 14:00 ` [PATCH 15/15] media: rcar_vin: Reject videobufs that are too small for current format William Towle
2015-06-12 9:22 ` Hans Verkuil [this message]
2015-06-19 12:07 ` HDMI and Composite capture on Lager, for kernel 4.1, version 3 Hans Verkuil
2015-06-22 14:41 ` William Towle
2015-06-22 14:45 ` Hans Verkuil
-- strict thread matches above, loose matches on Subject: below --
2015-06-25 9:30 HDMI and Composite capture on Lager, for kernel 4.1, version 4 William Towle
2015-06-25 9:31 ` [PATCH 15/15] media: rcar_vin: Reject videobufs that are too small for current format William Towle
2015-05-27 16:10 HDMI and Composite capture on Lager, for kernel 4.1, version 2 William Towle
2015-05-27 16:10 ` [PATCH 15/15] media: rcar_vin: Reject videobufs that are too small for current format William Towle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557AA4E8.40208@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-media@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=william.towle@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox