public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: William Towle <william.towle@codethink.co.uk>
Cc: linux-media@vger.kernel.org, linux-kernel@lists.codethink.co.uk,
	guennadi liakhovetski <g.liakhovetski@gmx.de>,
	sergei shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: HDMI and Composite capture on Lager, for kernel 4.1, version 3
Date: Mon, 22 Jun 2015 16:45:09 +0200	[thread overview]
Message-ID: <55881F75.2070707@xs4all.nl> (raw)
In-Reply-To: <alpine.DEB.2.02.1506221539110.7684@xk120.dyn.ducie.codethink.co.uk>

On 06/22/2015 04:41 PM, William Towle wrote:
> 
> Hi Hans,
>> I'm not sure if I've asked this before, but shouldn't soc-camera be extended
>> with support for the DV_TIMINGS ioctls in order to control the adv7604?
>>
>> It's peculiar that that is not included in this patch series...
> 
>    Rob tells me he did some work on this, but we don't have it passing
> muster with v4l2-compliance and since gstreamer tries a number of
> resolutions of its own accord and subsequently produces images and
> video without it we can make do without for our needs. I can include it
> in or alongside the next submission if you'd to see it.

Another reason not to use soc-camera.

It's really not a very suitable framework for this hardware.

> 
>    Regarding your other comments, in particular the specification of the
> following:
>  		.tdms_lock_mask = 0x43,
>  		.cable_det_mask = 0x01,
> ...when testing just the first input, these seem reasonable - in the
> case of tdms_lock_mask the two least significant bits represent
> V_LOCKED_RAW and DE_REGEN_LCK_RAW, and they are set in line with
> the value of TDMSPLL_LCK_A_RAW when queried.
> 
>    While an implementation suitable for testing both of the ADV7612's
> A and B inputs could just add TDMSPLL_LCK_B_RAW to tdms_lock mask,
> the cable detect function isn't so trivial: it would need to query two
> separate (and numerically non-adjacent) registers to do its job.
> 
>    For simplicity we would like to propose that our next iteration
> supports just the first input (which is sufficient for our current
> needs) and has commentary in appropriate places regarding its
> shortcomings, although we're open to alternative suggestions if there
> has already been discussion on the matter here.

I think supporting just the first input and commenting accordingly is the
best approach for now.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in

      reply	other threads:[~2015-06-22 14:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 13:59 HDMI and Composite capture on Lager, for kernel 4.1, version 3 William Towle
2015-06-03 13:59 ` [PATCH 01/15] ARM: shmobile: lager dts: Add entries for VIN HDMI input support William Towle
2015-06-03 13:59 ` [PATCH 02/15] media: soc_camera: rcar_vin: Add BT.709 24-bit RGB888 " William Towle
2015-06-12  6:31   ` Hans Verkuil
2015-06-03 13:59 ` [PATCH 03/15] media: adv7180: add of match table William Towle
2015-06-12  6:31   ` Hans Verkuil
2015-06-03 13:59 ` [PATCH 04/15] media: adv7604: chip info and formats for ADV7612 William Towle
2015-06-12  6:27   ` Hans Verkuil
2015-06-03 13:59 ` [PATCH 05/15] media: adv7604: document support for ADV7612 dual HDMI input decoder William Towle
2015-06-12  6:29   ` Hans Verkuil
2015-06-03 13:59 ` [PATCH 06/15] media: adv7604: ability to read default input port from DT William Towle
2015-06-12  6:29   ` Hans Verkuil
2015-06-03 13:59 ` [PATCH 07/15] ARM: shmobile: lager dts: specify default-input for ADV7612 William Towle
2015-06-03 13:59 ` [PATCH 08/15] v4l: subdev: Add pad config allocator and init William Towle
2015-06-03 13:59 ` [PATCH 09/15] media: soc_camera pad-aware driver initialisation William Towle
2015-06-12  9:15   ` Hans Verkuil
2015-06-14  9:40   ` Guennadi Liakhovetski
2015-06-03 13:59 ` [PATCH 10/15] media: rcar_vin: Use correct pad number in try_fmt William Towle
2015-06-12  9:17   ` Hans Verkuil
2015-06-20 10:59   ` Guennadi Liakhovetski
2015-06-03 13:59 ` [PATCH 11/15] media: soc_camera: soc_scale_crop: " William Towle
2015-06-12  9:18   ` Hans Verkuil
2015-06-20 11:38   ` Guennadi Liakhovetski
2015-06-20 11:45   ` Guennadi Liakhovetski
2015-06-03 13:59 ` [PATCH 12/15] media: soc_camera: Fill std field in enum_input William Towle
2015-06-03 14:00 ` [PATCH 13/15] media: soc_camera: Fix error reporting in expbuf William Towle
2015-06-03 14:00 ` [PATCH 14/15] media: soc_camera: fill in bus_info field William Towle
2015-06-12  9:22   ` Hans Verkuil
2015-06-03 14:00 ` [PATCH 15/15] media: rcar_vin: Reject videobufs that are too small for current format William Towle
2015-06-12  9:22   ` Hans Verkuil
2015-06-19 12:07 ` HDMI and Composite capture on Lager, for kernel 4.1, version 3 Hans Verkuil
2015-06-22 14:41   ` William Towle
2015-06-22 14:45     ` Hans Verkuil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55881F75.2070707@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-media@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=william.towle@codethink.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox