From: Andrzej Hajda <a.hajda@samsung.com>
To: Antonio Borneo <borneo.antonio@gmail.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] [media] s5c73m3: Remove redundant spi driver bus initialization
Date: Wed, 24 Jun 2015 07:53:52 +0200 [thread overview]
Message-ID: <558A45F0.2010601@samsung.com> (raw)
In-Reply-To: <1435071199-24630-1-git-send-email-borneo.antonio@gmail.com>
On 06/23/2015 04:53 PM, Antonio Borneo wrote:
> In ancient times it was necessary to manually initialize the bus
> field of an spi_driver to spi_bus_type. These days this is done in
> spi_register_driver(), so we can drop the manual assignment.
>
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
> To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> To: Kyungmin Park <kyungmin.park@samsung.com>
> To: Andrzej Hajda <a.hajda@samsung.com>
> To: linux-media@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Regards
Andrzej
> ---
> drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> index 63eb190..fa4a5eb 100644
> --- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> @@ -149,7 +149,6 @@ int s5c73m3_register_spi_driver(struct s5c73m3 *state)
> spidrv->remove = s5c73m3_spi_remove;
> spidrv->probe = s5c73m3_spi_probe;
> spidrv->driver.name = S5C73M3_SPI_DRV_NAME;
> - spidrv->driver.bus = &spi_bus_type;
> spidrv->driver.owner = THIS_MODULE;
> spidrv->driver.of_match_table = s5c73m3_spi_ids;
>
prev parent reply other threads:[~2015-06-24 5:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 14:45 [PATCH 0/6] Remove redundant spi driver bus initialization Antonio Borneo
2015-06-23 14:53 ` [PATCH 6/6] [media] s5c73m3: " Antonio Borneo
2015-06-24 5:53 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558A45F0.2010601@samsung.com \
--to=a.hajda@samsung.com \
--cc=borneo.antonio@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).