From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx08-00178001.pphosted.com ([91.207.212.93]:34523 "EHLO mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbbFXLDG (ORCPT ); Wed, 24 Jun 2015 07:03:06 -0400 Message-ID: <558A8E41.1060104@st.com> Date: Wed, 24 Jun 2015 13:02:25 +0200 From: Maxime Coquelin MIME-Version: 1.0 To: Mauro Carvalho Chehab , Linux Media Mailing List CC: Mauro Carvalho Chehab , Srinivas Kandagatla , Patrice Chotard , , Subject: Re: [PATCH 3/7] [media] use CONFIG_PM_SLEEP for suspend/resume References: <565e229d31527f166090d0368a3c348755838899.1435142906.git.mchehab@osg.samsung.com> In-Reply-To: <565e229d31527f166090d0368a3c348755838899.1435142906.git.mchehab@osg.samsung.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: On 06/24/2015 12:49 PM, Mauro Carvalho Chehab wrote: > Using CONFIG_PM_SLEEP suppress the warnings when the driver is > compiled without PM sleep functions: > > drivers/media/rc/st_rc.c:338:12: warning: ‘st_rc_suspend’ defined but not used [-Wunused-function] > drivers/media/rc/st_rc.c:359:12: warning: ‘st_rc_resume’ defined but not used [-Wunused-function] > > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c > index 979b40561b3a..37d040158dff 100644 > --- a/drivers/media/rc/st_rc.c > +++ b/drivers/media/rc/st_rc.c > @@ -334,7 +334,7 @@ err: > return ret; > } > > -#ifdef CONFIG_PM > +#ifdef CONFIG_PM_SLEEP > static int st_rc_suspend(struct device *dev) > { > struct st_rc_device *rc_dev = dev_get_drvdata(dev); Acked-by: Maxime Coquelin Thanks! Maxime