From: Lars-Peter Clausen <lars@metafoo.de>
To: Sakari Ailus <sakari.ailus@iki.fi>, Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] v4l2-event: v4l2_event_queue: do nothing if vdev == NULL
Date: Thu, 25 Jun 2015 11:22:02 +0200 [thread overview]
Message-ID: <558BC83A.1070308@metafoo.de> (raw)
In-Reply-To: <20150625091236.GH5904@valkosipuli.retiisi.org.uk>
On 06/25/2015 11:12 AM, Sakari Ailus wrote:
> Hi Hans,
>
> On Tue, Jun 23, 2015 at 11:20:23AM +0200, Hans Verkuil wrote:
>> If the vdev pointer == NULL, then just return.
>>
>> This makes it easier for subdev drivers to use this function without having to
>> check if the sd->devnode pointer is NULL or not.
>
> Do you have an example of when this would be useful? Isn't it a rather
> fundamental question to a driver whether or not it exposes a device node,
> i.e. why would a driver use v4l2_event_queue() in the first place if it does
> not expose a device node, and so the event interface?
The device node will only be created if the subdev driver supports it and if
the bridge driver requests it. So if the subdev driver supports it, but the
bridge driver does not request it there will be no devnode. The patch is to
handle that case.
This patch is a requirement for this series which adds support for direct
event notification to some subdev drivers. Why this is necessary and useful
can be found in the series patch description.
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/92808
- Lars
next prev parent reply other threads:[~2015-06-25 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 9:20 [PATCH] v4l2-event: v4l2_event_queue: do nothing if vdev == NULL Hans Verkuil
2015-06-25 9:12 ` Sakari Ailus
2015-06-25 9:22 ` Lars-Peter Clausen [this message]
2015-06-25 9:35 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558BC83A.1070308@metafoo.de \
--to=lars@metafoo.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox