From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Pawel Osciak <pawel@osciak.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Steven Rostedt <rostedt@goodmis.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
kamil@wypas.org, linux-media@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 1/2] [media] v4l2-mem2mem: set the queue owner field just as vb2_ioctl_reqbufs does
Date: Fri, 26 Jun 2015 11:35:47 +0200 [thread overview]
Message-ID: <558D1CF3.9030808@samsung.com> (raw)
In-Reply-To: <1435309372.3761.70.camel@pengutronix.de>
On 26/06/15 11:02, Philipp Zabel wrote:
> Am Freitag, den 26.06.2015, 10:28 +0200 schrieb Sylwester Nawrocki:
> [...]
>>>> > >> How about modifying v4l2_m2m_ioctl_reqbufs() instead ?
>>> > >
>>> > > The coda, gsc-m2m, m2m-deinterlace, mx2_emmaprp, and sh_veu drivers all
>>> > > have their own implementation of vidioc_reqbufs that call
>>> > > v4l2_m2m_reqbufs directly.
>>> > > Maybe this should be moved into v4l2_m2m_ioctl_reqbufs after all drivers
>>> > > are updated to use it instead of v4l2_m2m_reqbufs.
>> >
>> > In case of some of the above listed drivers it shouldn't be difficult
>> > and would be nice to convert to the generic v4l2_m2m_ioctl* callbacks.
>> >
>> > Anyway, I guess your code change makes sense, just the comment might
>> > be a little bit misleading. vq->owner will always be one and the same
>> > file handle, unless I'm missing something.
>
> True. Since the m2m_ctx containing the vb2_queue is attached to the file
> handle, this will only ever get called with the same file handle for a
> given queue. s/we have a new owner/we have an owner/ ?
Sounds good enough to me.
next prev parent reply other threads:[~2015-06-26 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 10:01 [PATCH 1/2] [media] v4l2-mem2mem: set the queue owner field just as vb2_ioctl_reqbufs does Philipp Zabel
2015-06-25 10:01 ` [PATCH 2/2] [media] videobuf2: add trace events Philipp Zabel
2015-06-25 13:07 ` Steven Rostedt
2015-06-25 16:33 ` Philipp Zabel
2015-06-25 13:11 ` [PATCH 1/2] [media] v4l2-mem2mem: set the queue owner field just as vb2_ioctl_reqbufs does Sylwester Nawrocki
2015-06-25 15:12 ` Philipp Zabel
2015-06-26 8:28 ` Sylwester Nawrocki
2015-06-26 9:02 ` Philipp Zabel
2015-06-26 9:35 ` Sylwester Nawrocki [this message]
2015-06-25 14:10 ` Kamil Debski
2015-06-25 16:34 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D1CF3.9030808@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=hans.verkuil@cisco.com \
--cc=kamil@wypas.org \
--cc=kernel@pengutronix.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@osg.samsung.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel@osciak.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox