From: Lars-Peter Clausen <lars@metafoo.de>
To: Hans Verkuil <hverkuil@xs4all.nl>, Hans Verkuil <hans.verkuil@cisco.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 4/5] [media] adv7604: Deliver resolution change events to userspace
Date: Mon, 13 Jul 2015 13:01:34 +0200 [thread overview]
Message-ID: <55A39A8E.8010803@metafoo.de> (raw)
In-Reply-To: <55A37E99.4060902@xs4all.nl>
On 07/13/2015 11:02 AM, Hans Verkuil wrote:
>> +static int adv76xx_subscribe_event(struct v4l2_subdev *sd,
>> + struct v4l2_fh *fh,
>> + struct v4l2_event_subscription *sub)
>> +{
>> + switch (sub->type) {
>> + case V4L2_EVENT_SOURCE_CHANGE:
>> + return v4l2_src_change_event_subdev_subscribe(sd, fh, sub);
>> + case V4L2_EVENT_CTRL:
>> + return v4l2_event_subdev_unsubscribe(sd, fh, sub);
>
> This should be v4l2_ctrl_subdev_subscribe_event() of course. I'll fix this in
> the patch before sending the pull request. Ditto for the adv7842 patch.
Thanks.
next prev parent reply other threads:[~2015-07-13 11:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 16:50 [PATCH 1/5] [media] adv7604: Add support for control event notifications Lars-Peter Clausen
2015-06-24 16:50 ` [PATCH 2/5] [media] adv7842: " Lars-Peter Clausen
2015-06-24 16:50 ` [PATCH 3/5] [media] Add helper function for subdev " Lars-Peter Clausen
2015-06-25 9:47 ` Sakari Ailus
2015-06-25 10:41 ` Lars-Peter Clausen
2015-06-24 16:50 ` [PATCH 4/5] [media] adv7604: Deliver resolution change events to userspace Lars-Peter Clausen
2015-06-25 10:21 ` Sakari Ailus
2015-06-25 10:44 ` Lars-Peter Clausen
2015-07-13 9:02 ` Hans Verkuil
2015-07-13 11:01 ` Lars-Peter Clausen [this message]
2015-06-24 16:50 ` [PATCH 5/5] [media] adv7842: " Lars-Peter Clausen
2015-06-25 10:24 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A39A8E.8010803@metafoo.de \
--to=lars@metafoo.de \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).