From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:38958 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbbGQO7z (ORCPT ); Fri, 17 Jul 2015 10:59:55 -0400 Message-ID: <55A9182D.2020800@xs4all.nl> Date: Fri, 17 Jul 2015 16:58:53 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Philipp Zabel CC: Mats Randgaard , linux-media@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 5/5] [media] tc358743: allow event subscription References: <1436533897-3060-1-git-send-email-p.zabel@pengutronix.de> <1436533897-3060-5-git-send-email-p.zabel@pengutronix.de> <55A39BE3.2070905@xs4all.nl> <1436868609.3793.25.camel@pengutronix.de> In-Reply-To: <1436868609.3793.25.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 07/14/2015 12:10 PM, Philipp Zabel wrote: > Am Montag, den 13.07.2015, 13:07 +0200 schrieb Hans Verkuil: >> On 07/10/2015 03:11 PM, Philipp Zabel wrote: >>> This is useful to subscribe to HDMI hotplug events via the >>> V4L2_CID_DV_RX_POWER_PRESENT control. >>> >>> Signed-off-by: Philipp Zabel >>> --- >>> drivers/media/i2c/tc358743.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c >>> index 4a889d4..91fffa8 100644 >>> --- a/drivers/media/i2c/tc358743.c >>> +++ b/drivers/media/i2c/tc358743.c >>> @@ -40,6 +40,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> >>> @@ -1604,6 +1605,8 @@ static const struct v4l2_subdev_core_ops tc358743_core_ops = { >>> .s_register = tc358743_s_register, >>> #endif >>> .interrupt_service_routine = tc358743_isr, >>> + .subscribe_event = v4l2_ctrl_subdev_subscribe_event, >> >> Ah, they are set here. >> >> But note that v4l2_ctrl_subdev_subscribe_event is not enough, since this driver >> also issues the V4L2_EVENT_SOURCE_CHANGE event. >> >> See this patch on how to do that: >> >> http://git.linuxtv.org/cgit.cgi/hverkuil/media_tree.git/commit/?h=for-v4.3a&id=85c9b0b83795dac3d27043619a727af5c7313fe7 >> >> Note: requires the new v4l2_subdev_notify_event function that's not yet >> merged (just posted the pull request for that). > > Ok, I think I'll split this up and send patch 5 separately, then. FYI: the v4l2_subdev_notify_event was just merged today. Regards, Hans