From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from lists.s-osg.org ([54.187.51.154]:53610 "EHLO lists.s-osg.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752134AbbGTPzy (ORCPT <rfc822;linux-media@vger.kernel.org>);
	Mon, 20 Jul 2015 11:55:54 -0400
Message-ID: <55AD1A06.3040902@osg.samsung.com>
Date: Mon, 20 Jul 2015 09:55:50 -0600
From: Shuah Khan <shuahkh@osg.samsung.com>
MIME-Version: 1.0
To: Dan Carpenter <dan.carpenter@oracle.com>
CC: mchehab@osg.samsung.com, hans.verkuil@cisco.com,
	laurent.pinchart@ideasonboard.com, tiwai@suse.de, perex@perex.cz,
	crope@iki.fi, sakari.ailus@linux.intel.com, arnd@arndb.de,
	stefanr@s5r6.in-berlin.de, ruchandani.tina@gmail.com,
	chehabrafael@gmail.com, prabhakar.csengg@gmail.com,
	chris.j.arges@canonical.com, agoode@google.com,
	pierre-louis.bossart@linux.intel.com, gtmkramer@xs4all.nl,
	clemens@ladisch.de, daniel@zonque.org, vladcatoi@gmail.com,
	misterpib@gmail.com, damien@zamaudio.com, pmatilai@laiskiainen.org,
	takamichiho@gmail.com, normalperson@yhbt.net,
	bugzilla.frnkcg@spamgourmet.com, joe@oampo.co.uk,
	calcprogrammer1@gmail.com, jussi@sonarnerd.net,
	linux-media@vger.kernel.org, alsa-devel@alsa-project.org,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH 6/7] media: au0828 change to use Managed Media Controller
 API
References: <cover.1436917513.git.shuahkh@osg.samsung.com> <3643452be528b2e53cea592db22b4e0ada32456b.1436917513.git.shuahkh@osg.samsung.com> <20150720084220.GG5422@mwanda>
In-Reply-To: <20150720084220.GG5422@mwanda>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

On 07/20/2015 02:42 AM, Dan Carpenter wrote:
> Sorry for this nit-pick and some time after you sent this patch.  It's
> not a redo the patch" complaint, it's something that could be fixed
> later.
> 
> On Tue, Jul 14, 2015 at 06:34:05PM -0600, Shuah Khan wrote:
>> @@ -131,10 +132,12 @@ static void au0828_unregister_media_device(struct au0828_dev *dev)
>>  {
>>  
>>  #ifdef CONFIG_MEDIA_CONTROLLER
>> -	if (dev->media_dev) {
>> -		media_device_unregister(dev->media_dev);
>> -		kfree(dev->media_dev);
>> -		dev->media_dev = NULL;
>> +	if (dev->media_dev &&
>> +		media_devnode_is_registered(&dev->media_dev->devnode)) {
>> +			media_device_unregister_entity_notify(dev->media_dev,
>> +							&dev->entity_notify);
>> +			media_device_unregister(dev->media_dev);
>> +			dev->media_dev = NULL;
> 
> 
> The indenting is slightly off here.  It should be:
> 
> 	if (dev->media_dev &&
> 	    media_devnode_is_registered(&dev->media_dev->devnode)) {
> 		media_device_unregister_entity_notify(dev->media_dev,
> 						      &dev->entity_notify);
> 		media_device_unregister(dev->media_dev);
> 		dev->media_dev = NULL;
> 	}
> 
> Aligning if statements using spaces like that is nicer and checkpatch.pl
> won't complain.
> 

Yeah. I try to do that whenever. In this case, if I align, the line
becomes longer than 80 chars adding more things to worry about. In
such cases, I tend to not worry about aligning.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978