From: Hans Verkuil <hverkuil@xs4all.nl>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Zahari Doychev <zahari.doychev@linux.com>
Cc: linux-media@vger.kernel.org, mchehab@osg.samsung.com,
k.debski@samsung.com, hans.verkuil@cisco.com
Subject: Re: [PATCH 1/2] [media] coda: fix sequence counter increment
Date: Tue, 28 Jul 2015 10:54:04 +0200 [thread overview]
Message-ID: <55B7432C.7090001@xs4all.nl> (raw)
In-Reply-To: <1436370559.3079.80.camel@pengutronix.de>
On 07/08/2015 05:49 PM, Philipp Zabel wrote:
> Hi Zahari,
>
> Am Mittwoch, den 08.07.2015, 15:37 +0200 schrieb Zahari Doychev:
>> The coda context queue sequence counter is incremented only if the vb2
>> source buffer payload is non zero. This makes possible to signal EOS
>> otherwise the condition in coda_buf_is_end_of_stream is never met or more
>> precisely buf->v4l2_buf.sequence == (ctx->qsequence - 1) never happens.
>>
>> Signed-off-by: Zahari Doychev <zahari.doychev@linux.com>
>
> I think we should instead avoid calling coda_bitstream_queue with zero
> payload buffers altogether and dump them in coda_fill_bitstream already.
Philipp, is this still outstanding or did you fix this already according
to the suggestion you made above?
Just wondering whether to set this bug report to 'Rejected' or 'Changes
Requested'.
Regards,
Hans
next prev parent reply other threads:[~2015-07-28 8:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 13:37 [PATCH 0/2] RFC: m2m device fixes Zahari Doychev
2015-07-08 13:37 ` [PATCH 1/2] [media] coda: fix sequence counter increment Zahari Doychev
2015-07-08 15:49 ` Philipp Zabel
2015-07-28 8:54 ` Hans Verkuil [this message]
2015-07-28 10:25 ` Philipp Zabel
2015-08-03 6:24 ` Zahari Doychev
2015-07-08 13:37 ` [PATCH 2/2] [media] m2m: fix bad unlock balance Zahari Doychev
2015-07-28 9:02 ` Hans Verkuil
2015-08-12 11:42 ` Marek Szyprowski
2015-08-12 15:50 ` Kamil Debski
2015-08-14 11:57 ` Hans Verkuil
2015-08-17 7:37 ` Zahari Doychev
2015-07-28 9:03 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B7432C.7090001@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=hans.verkuil@cisco.com \
--cc=k.debski@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=p.zabel@pengutronix.de \
--cc=zahari.doychev@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox