Re: [PATCH v7 21/44] [media] dvbdev: add support for interfaces

[Hans Verkuil <hverkuil@xs4all.nl>]

On 08/25/15 12:04, Mauro Carvalho Chehab wrote:
> Em Tue, 25 Aug 2015 09:50:25 +0200
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> 
>> On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote:
>>> Now that the infrastruct for that is set, add support for
>>> interfaces.
>>>
>>> Please notice that we're missing two links:
>>> 	DVB FE intf    -> tuner
>>> 	DVB demux intf -> dvr
>>>
>>> Those should be added latter, after having the entire graph
>>
>> s/latter/later/
>>
>>> set. With the current infrastructure, those should be added
>>> at dvb_create_media_graph(), but it would also require some
>>> extra core changes, to allow the function to enumerate the
>>> interfaces.
>>>
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>>>
>>> diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
>>> index 65f59f2124b4..747372ba4fe1 100644
>>> --- a/drivers/media/dvb-core/dvbdev.c
>>> +++ b/drivers/media/dvb-core/dvbdev.c
>>> @@ -180,14 +180,35 @@ skip:
>>>  	return -ENFILE;
>>>  }
>>>  
>>> -static void dvb_register_media_device(struct dvb_device *dvbdev,
>>> -				      int type, int minor)
>>> +static void dvb_create_media_entity(struct dvb_device *dvbdev,
>>> +				       int type, int minor)
>>>  {
>>>  #if defined(CONFIG_MEDIA_CONTROLLER_DVB)
>>>  	int ret = 0, npads;
>>>  
>>> -	if (!dvbdev->adapter->mdev)
>>> +	switch (type) {
>>> +	case DVB_DEVICE_FRONTEND:
>>> +		npads = 2;
>>> +		break;
>>> +	case DVB_DEVICE_DEMUX:
>>> +		npads = 2;
>>> +		break;
>>> +	case DVB_DEVICE_CA:
>>> +		npads = 2;
>>> +		break;
>>> +	case DVB_DEVICE_NET:
>>> +		/*
>>> +		 * We should be creating entities for the MPE/ULE
>>> +		 * decapsulation hardware (or software implementation).
>>> +		 *
>>> +		 * However, as the number of for the MPE/ULE may not be fixed,
>>> +		 * and we don't have yet dynamic support for PADs at the
>>> +		 * Media Controller.
>>
>> However what? You probably want to add something like:
>>
>> However, ... at the Media Controller, we don't make this entity yet.
> 
> What about this:
> 		 * However, the number of for the MPE/ULE decaps may not be
> 		 * fixed. As we don't have yet dynamic support for PADs at
> 		 * the Media Controller, let's not create those yet.

I'd be explicit:

s/those/decap entities/

Other than that this is OK.

Regards,

	Hans