From: Hans de Goede <hdegoede@redhat.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Mian Yousaf Kaukab <yousaf.kaukab@intel.com>,
laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org,
mchehab@osg.samsung.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue
Date: Wed, 9 Sep 2015 10:30:12 +0200 [thread overview]
Message-ID: <55EFEE14.5050100@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1509081035070.1533-100000@iolanthe.rowland.org>
Hi,
On 08-09-15 16:36, Alan Stern wrote:
> On Tue, 8 Sep 2015, Hans de Goede wrote:
>
>> Hi,
>>
>> On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote:
>>> urb completion callback is executed in host controllers interrupt
>>> context. To keep preempt disable time short, add urbs to a list on
>>> completion and schedule work to process the list.
>>>
>>> Moreover, save timestamp and sof number in the urb completion callback
>>> to avoid any delays.
>>
>> Erm, I thought that we had already moved to using threaded interrupt
>> handling for the urb completion a while (1-2 years ?) back. Is this then
>> still needed ?
>
> We moved to handling URB completions in a tasklet, not a threaded
> handler.
Right.
> (Similar idea, though.) And the change was made in only one
> or two HCDs, not in all of them.
Ah, I was under the impression this was a core change, not a per
hcd change.
Regards,
Hans
next prev parent reply other threads:[~2015-09-09 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 16:23 [PATCH v1] media: uvcvideo: handle urb completion in a work queue Mian Yousaf Kaukab
2015-09-08 8:58 ` Oliver Neukum
2015-09-08 12:53 ` Hans de Goede
2015-09-08 14:36 ` Alan Stern
2015-09-09 8:30 ` Hans de Goede [this message]
2015-09-09 8:43 ` Laurent Pinchart
2015-09-09 15:14 ` Alan Stern
2015-09-09 16:02 ` Laurent Pinchart
2015-09-09 16:29 ` Alan Stern
2015-09-10 8:00 ` Kaukab, Yousaf
2015-09-09 14:42 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EFEE14.5050100@redhat.com \
--to=hdegoede@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=stern@rowland.harvard.edu \
--cc=yousaf.kaukab@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox