Re: [RFC PATCH v4 1/8] [media] videobuf2: Replace videobuf2-core with videobuf2-v4l2

[Junghak Sung <jh1009.sung@samsung.com>]

On 09/11/2015 05:02 PM, Hans Verkuil wrote:
> On 09/09/2015 01:19 PM, Junghak Sung wrote:
>> Make videobuf2-v4l2 as a wrapper of videobuf2-core for v4l2-use.
>> And replace videobuf2-core.h with videobuf2-v4l2.h.
>> This renaming change should be accompanied by the modifications
>> of all device drivers that include videobuf2-core.h.
>> It can be done with just running this shell script.
>>
>> replace()
>> {
>> str1=$1
>> str2=$2
>> dir=$3
>> for file in $(find $dir -name *.h -o -name *.c -o -name Makefile)
>> do
>>      echo $file
>>      sed "s/$str1/$str2/g" $file > $file.out
>>      mv $file.out $file
>> done
>> }
>>
>> replace "videobuf2-core" "videobuf2-v4l2" "include/media/"
>> replace "videobuf2-core" "videobuf2-v4l2" "drivers/media/"
>> replace "videobuf2-core" "videobuf2-v4l2" "drivers/usb/gadget/"
>>
>> Signed-off-by: Junghak Sung <jh1009.sung@samsung.com>
>> Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com>
>> Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
>> Acked-by: Inki Dae <inki.dae@samsung.com>
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> However, see one small comment below:
>
> <snip>
>
>> diff --git a/include/media/videobuf2-dvb.h b/include/media/videobuf2-dvb.h
>> index 8f61456..bef9127 100644
>> --- a/include/media/videobuf2-dvb.h
>> +++ b/include/media/videobuf2-dvb.h
>> @@ -6,7 +6,7 @@
>>   #include <dvb_demux.h>
>>   #include <dvb_net.h>
>>   #include <dvb_frontend.h>
>> -#include <media/videobuf2-core.h>
>> +#include <media/videobuf2-v4l2.h>
>
> I actually think this should remain core.h since videobuf2-dvb.c/h has
> nothing to do with v4l2.
>
> Regards,
>
> 	Hans
>

I agree with you.
In this patch series, vb2_thread_*() are still remained in
videobuf2-v4l2, because vb2_tread_*() and vb2_fileio_*() have
dependencies on v4l2 and it is not easy to remove them completely.
I'll try to remove the dependencies and make
videobuf2-dvb to include videobuf2-core instead of videobuf2-v4l2
at next round.

Regards,
Junghak

>>
>>   struct vb2_dvb {
>>   	/* filling that the job of the driver */
>
>