Re: [PATCH v3 9/9] media: starfive: Add Starfive Camera Subsystem driver

kernel test robot
2023-04-01T05:17:22Z

Hi Jack,

I love your patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next linus/master v6.3-rc4 next-20230331]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Jack-Zhu/media-dt-bindings-Add-bindings-for-JH7110-Camera-Subsystem/20230331-202001
base: git://linuxtv.org/media_tree.git master
patch link: https://lore.kernel.org/r/20230331121826.96973-10-jack.zhu%40starfivetech.com
patch subject: [PATCH v3 9/9] media: starfive: Add Starfive Camera Subsystem driver
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230401/202304011300.mT9MprJK-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/421adbf9815b633e8bac5da7146c33aac01e283c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jack-Zhu/media-dt-bindings-Add-bindings-for-JH7110-Camera-Subsystem/20230331-202001
git checkout 421adbf9815b633e8bac5da7146c33aac01e283c
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 olddefconfig
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304011300.mT9MprJK-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/media/platform/starfive/stf_vin.c: In function 'stf_vin_map_isp_pad':
drivers/media/platform/starfive/stf_vin.c:99:24: warning: implicit conversion from 'enum isp_line_id' to 'enum isp_pad_id' [-Wenum-conversion]
99 | pad_id = vin_map_isp_line(line);
| ^
drivers/media/platform/starfive/stf_vin.c: In function 'vin_output_init_addrs':
drivers/media/platform/starfive/stf_vin.c:683:20: warning: variable 'pong_addr' set but not used [-Wunused-but-set-variable]
683 | dma_addr_t pong_addr;
| ^~~~~~~~~
At top level:
>> drivers/media/platform/starfive/stf_vin.c:33:32: warning: 'vin_formats_raw' defined but not used [-Wunused-const-variable=]
33 | static const struct vin_format vin_formats_raw[] = {
| ^~~~~~~~~~~~~~~

vim +/vin_formats_raw +33 drivers/media/platform/starfive/stf_vin.c

32
> 33 static const struct vin_format vin_formats_raw[] = {
34 { MEDIA_BUS_FMT_SBGGR12_1X12, 12},
35 { MEDIA_BUS_FMT_SRGGB12_1X12, 12},
36 { MEDIA_BUS_FMT_SGRBG12_1X12, 12},
37 { MEDIA_BUS_FMT_SGBRG12_1X12, 12},
38 };
39

--
0-DAY CI Kernel Test Service