From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-media@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd()
Date: Mon, 28 Sep 2015 14:59:41 +0300 [thread overview]
Message-ID: <56092BAD.3080104@cogentembedded.com> (raw)
In-Reply-To: <20150927170826.5063f729@recife.lan>
Hello.
On 9/27/2015 11:08 PM, Mauro Carvalho Chehab wrote:
>>>> This is an automatic generated email to let you know that the following
>>>> patch were queued at the
>>>> http://git.linuxtv.org/cgit.cgi/media_tree.git tree:
>>>>
>>>> Subject: [media] rcar_vin: call g_std() instead of querystd()
>>>> Author: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> Date: Thu Sep 3 20:18:05 2015 -0300
>>>>
>>>> Hans Verkuil says: "The only place querystd can be called is in the
>>>> QUERYSTD
>>>> ioctl, all other ioctls should use the last set standard." So call the
>>>> g_std()
>>>> subdevice method instead of querystd() in the driver's set_fmt() method.
>>>>
>>>> Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>>>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>>> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>>>
>>> Note that merging this patch without the 2 patches preceding it in the the
>>> series will break the frame capture.
>>
>> Ouch, the other 2 patches were not for me, I wasn't even CC'ed on them,
>> but I guess I should have read patch 0/3, on which I was indeed CC'ed and
>> just have acked this patch instead of pushing it... Mauro, I guess the
>> only two possibilities to fix this now is to also push the other two
>> patches or to revert this one. Sorry about this.
> Well, if the other two patches are OK, then send me a pull request,
> and I'll merge them.
The adv7180 patch was rejected by Hans. I'm still hoping Lars-Peter will
look into removing the auto-detect feature from this driver.
MBR, Sergei
prev parent reply other threads:[~2015-09-28 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1ZfZpS-0004ra-EU@www.linuxtv.org>
2015-09-25 21:40 ` [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd() Sergei Shtylyov
2015-09-27 19:23 ` Guennadi Liakhovetski
2015-09-27 20:08 ` Mauro Carvalho Chehab
2015-09-28 11:59 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56092BAD.3080104@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=g.liakhovetski@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).