* Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd() [not found] <E1ZfZpS-0004ra-EU@www.linuxtv.org> @ 2015-09-25 21:40 ` Sergei Shtylyov 2015-09-27 19:23 ` Guennadi Liakhovetski 0 siblings, 1 reply; 4+ messages in thread From: Sergei Shtylyov @ 2015-09-25 21:40 UTC (permalink / raw) To: mchehab, linux-media Hello. On 09/25/2015 11:32 PM, Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch were queued at the > http://git.linuxtv.org/cgit.cgi/media_tree.git tree: > > Subject: [media] rcar_vin: call g_std() instead of querystd() > Author: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Date: Thu Sep 3 20:18:05 2015 -0300 > > Hans Verkuil says: "The only place querystd can be called is in the QUERYSTD > ioctl, all other ioctls should use the last set standard." So call the g_std() > subdevice method instead of querystd() in the driver's set_fmt() method. > > Reported-by: Hans Verkuil <hverkuil@xs4all.nl> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> Note that merging this patch without the 2 patches preceding it in the the series will break the frame capture. MBR, Sergei ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd() 2015-09-25 21:40 ` [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd() Sergei Shtylyov @ 2015-09-27 19:23 ` Guennadi Liakhovetski 2015-09-27 20:08 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 4+ messages in thread From: Guennadi Liakhovetski @ 2015-09-27 19:23 UTC (permalink / raw) To: Sergei Shtylyov; +Cc: mchehab, linux-media On Sat, 26 Sep 2015, Sergei Shtylyov wrote: > Hello. > > On 09/25/2015 11:32 PM, Mauro Carvalho Chehab wrote: > > > This is an automatic generated email to let you know that the following > > patch were queued at the > > http://git.linuxtv.org/cgit.cgi/media_tree.git tree: > > > > Subject: [media] rcar_vin: call g_std() instead of querystd() > > Author: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Date: Thu Sep 3 20:18:05 2015 -0300 > > > > Hans Verkuil says: "The only place querystd can be called is in the > > QUERYSTD > > ioctl, all other ioctls should use the last set standard." So call the > > g_std() > > subdevice method instead of querystd() in the driver's set_fmt() method. > > > > Reported-by: Hans Verkuil <hverkuil@xs4all.nl> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > Note that merging this patch without the 2 patches preceding it in the the > series will break the frame capture. Ouch, the other 2 patches were not for me, I wasn't even CC'ed on them, but I guess I should have read patch 0/3, on which I was indeed CC'ed and just have acked this patch instead of pushing it... Mauro, I guess the only two possibilities to fix this now is to also push the other two patches or to revert this one. Sorry about this. Thanks Guennadi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd() 2015-09-27 19:23 ` Guennadi Liakhovetski @ 2015-09-27 20:08 ` Mauro Carvalho Chehab 2015-09-28 11:59 ` Sergei Shtylyov 0 siblings, 1 reply; 4+ messages in thread From: Mauro Carvalho Chehab @ 2015-09-27 20:08 UTC (permalink / raw) To: Guennadi Liakhovetski; +Cc: Sergei Shtylyov, linux-media Em Sun, 27 Sep 2015 21:23:29 +0200 Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu: > On Sat, 26 Sep 2015, Sergei Shtylyov wrote: > > > Hello. > > > > On 09/25/2015 11:32 PM, Mauro Carvalho Chehab wrote: > > > > > This is an automatic generated email to let you know that the following > > > patch were queued at the > > > http://git.linuxtv.org/cgit.cgi/media_tree.git tree: > > > > > > Subject: [media] rcar_vin: call g_std() instead of querystd() > > > Author: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > Date: Thu Sep 3 20:18:05 2015 -0300 > > > > > > Hans Verkuil says: "The only place querystd can be called is in the > > > QUERYSTD > > > ioctl, all other ioctls should use the last set standard." So call the > > > g_std() > > > subdevice method instead of querystd() in the driver's set_fmt() method. > > > > > > Reported-by: Hans Verkuil <hverkuil@xs4all.nl> > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > > > Note that merging this patch without the 2 patches preceding it in the the > > series will break the frame capture. > > Ouch, the other 2 patches were not for me, I wasn't even CC'ed on them, > but I guess I should have read patch 0/3, on which I was indeed CC'ed and > just have acked this patch instead of pushing it... Mauro, I guess the > only two possibilities to fix this now is to also push the other two > patches or to revert this one. Sorry about this. Well, if the other two patches are OK, then send me a pull request, and I'll merge them. > > Thanks > Guennadi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd() 2015-09-27 20:08 ` Mauro Carvalho Chehab @ 2015-09-28 11:59 ` Sergei Shtylyov 0 siblings, 0 replies; 4+ messages in thread From: Sergei Shtylyov @ 2015-09-28 11:59 UTC (permalink / raw) To: Mauro Carvalho Chehab, Guennadi Liakhovetski Cc: linux-media, Lars-Peter Clausen Hello. On 9/27/2015 11:08 PM, Mauro Carvalho Chehab wrote: >>>> This is an automatic generated email to let you know that the following >>>> patch were queued at the >>>> http://git.linuxtv.org/cgit.cgi/media_tree.git tree: >>>> >>>> Subject: [media] rcar_vin: call g_std() instead of querystd() >>>> Author: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>> Date: Thu Sep 3 20:18:05 2015 -0300 >>>> >>>> Hans Verkuil says: "The only place querystd can be called is in the >>>> QUERYSTD >>>> ioctl, all other ioctls should use the last set standard." So call the >>>> g_std() >>>> subdevice method instead of querystd() in the driver's set_fmt() method. >>>> >>>> Reported-by: Hans Verkuil <hverkuil@xs4all.nl> >>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> >>>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> >>>> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> >>> >>> Note that merging this patch without the 2 patches preceding it in the the >>> series will break the frame capture. >> >> Ouch, the other 2 patches were not for me, I wasn't even CC'ed on them, >> but I guess I should have read patch 0/3, on which I was indeed CC'ed and >> just have acked this patch instead of pushing it... Mauro, I guess the >> only two possibilities to fix this now is to also push the other two >> patches or to revert this one. Sorry about this. > Well, if the other two patches are OK, then send me a pull request, > and I'll merge them. The adv7180 patch was rejected by Hans. I'm still hoping Lars-Peter will look into removing the auto-detect feature from this driver. MBR, Sergei ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-28 11:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1ZfZpS-0004ra-EU@www.linuxtv.org>
2015-09-25 21:40 ` [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd() Sergei Shtylyov
2015-09-27 19:23 ` Guennadi Liakhovetski
2015-09-27 20:08 ` Mauro Carvalho Chehab
2015-09-28 11:59 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).