Re: [Patch v2 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture driver

[Hans Verkuil <hverkuil@xs4all.nl>]

On 10/16/2015 05:07 PM, Hans Verkuil wrote:
> On 09/21/2015 10:04 PM, Benoit Parrot wrote:
>> The Camera Adaptation Layer (CAL) is a block which consists of a dual
>> port CSI2/MIPI camera capture engine.
>> Port #0 can handle CSI2 camera connected to up to 4 data lanes.
>> Port #1 can handle CSI2 camera connected to up to 2 data lanes.
>> The driver implements the required API/ioctls to be V4L2 compliant.
>> Driver supports the following:
>>     - V4L2 API using DMABUF/MMAP buffer access based on videobuf2 api
>>     - Asynchronous sensor sub device registration
>>     - DT support
>>
>> Signed-off-by: Benoit Parrot <bparrot@ti.com>
>> ---
>>  drivers/media/platform/Kconfig           |   12 +
>>  drivers/media/platform/Makefile          |    2 +
>>  drivers/media/platform/ti-vpe/Makefile   |    4 +
>>  drivers/media/platform/ti-vpe/cal.c      | 2161 ++++++++++++++++++++++++++++++
>>  drivers/media/platform/ti-vpe/cal_regs.h |  779 +++++++++++
>>  5 files changed, 2958 insertions(+)
>>  create mode 100644 drivers/media/platform/ti-vpe/cal.c
>>  create mode 100644 drivers/media/platform/ti-vpe/cal_regs.h
>>
>> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
>> index dc75694ac12d..c7f5704c56a2 100644
>> --- a/drivers/media/platform/Kconfig
>> +++ b/drivers/media/platform/Kconfig
>> @@ -120,6 +120,18 @@ source "drivers/media/platform/s5p-tv/Kconfig"
>>  source "drivers/media/platform/am437x/Kconfig"
>>  source "drivers/media/platform/xilinx/Kconfig"
>>  
>> +config VIDEO_TI_CAL
>> +	tristate "TI CAL (Camera Adaptation Layer) driver"
>> +	depends on VIDEO_DEV && VIDEO_V4L2 && SOC_DRA7XX
>> +	depends on VIDEO_V4L2_SUBDEV_API
>> +	depends on VIDEOBUF2_DMA_CONTIG
> 
> This should be:
> 
>        depends on VIDEO_DEV && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
>        depends on SOC_DRA7XX || COMPILE_TEST
>        select VIDEOBUF2_DMA_CONTIG
> 
>> +	default n
>> +	---help---
>> +	  Support for the TI CAL (Camera Adaptation Layer) block
>> +	  found on DRA72X SoC.
>> +	  In TI Technical Reference Manual this module is referred as
>> +	  Camera Interface Subsystem (CAMSS).
>> +
>>  endif # V4L_PLATFORM_DRIVERS
>>  
>>  menuconfig V4L_MEM2MEM_DRIVERS
> 
> By compiling with COMPILE_TEST I found a number of compile warnings and it also no
> longer compiled due to vb2 changes. Both are fixed in the patch below.
> 
> SoB for the patch: Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> 
> That said, I'll postpone merging this until the remainder of the vb2 split patches
> have been merged. When that's done this driver will have to be changed some more.

OK, the vb2 split patches were just merged. Can you rebase and repost?

Thanks,

	Hans