From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Tomasz Figa <tfiga@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kamil Debski <kamil@wypas.org>,
Jeongtae Park <jtp.park@samsung.com>,
Andrzej Hajda <a.hajda@samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Maxime Jourdan <mjourdan@baylibre.com>
Subject: Re: [PATCHv2 04/12] media: s5p_mfc_dec: set flags for OUTPUT coded formats
Date: Fri, 16 Aug 2019 13:37:08 +0200 [thread overview]
Message-ID: <563e44c1-afed-4b08-b7f9-ebe30c17d522@samsung.com> (raw)
In-Reply-To: <CAAFQd5DQ_oAmsqBWVDWrCiTNxGH5PJ0OdX5Qk_=M+RKnbr=-_g@mail.gmail.com>
Hi Tomasz,
On 2019-08-15 12:14, Tomasz Figa wrote:
> Hi Hans,
>
> On Mon, Aug 12, 2019 at 8:05 PM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>> From: Maxime Jourdan <mjourdan@baylibre.com>
>>
>> Tag all the coded formats where the s5p_mfc decoder supports dynamic
>> resolution switching or has a bytestream parser.
>>
> I believe it depends on the MFC hardware version. v5 might have some
> additional restrictions.
>
> Let me add some more folks to figure out.
IIRC MFC v5 also supported resolution change.
>> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> [hverkuil-cisco@xs4all.nl: added CONTINUOUS_BYTESTREAM]
>> ---
>> .../media/platform/s5p-mfc/s5p_mfc_common.h | 1 +
>> drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 18 ++++++++++++++++++
>> 2 files changed, 19 insertions(+)
>>
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
>> index 96d1ecd1521b..31b133af91eb 100644
>> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
>> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
>> @@ -723,6 +723,7 @@ struct s5p_mfc_fmt {
>> enum s5p_mfc_fmt_type type;
>> u32 num_planes;
>> u32 versions;
>> + u32 flags;
>> };
>>
>> /**
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
>> index 61e144a35201..1423c33c70cb 100644
>> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
>> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
>> @@ -62,6 +62,8 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V5PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION |
>> + V4L2_FMT_FLAG_CONTINUOUS_BYTESTREAM,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_H264_MVC,
>> @@ -69,6 +71,8 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V6PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION |
>> + V4L2_FMT_FLAG_CONTINUOUS_BYTESTREAM,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_H263,
>> @@ -76,6 +80,7 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V5PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_MPEG1,
>> @@ -83,6 +88,8 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V5PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION |
>> + V4L2_FMT_FLAG_CONTINUOUS_BYTESTREAM,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_MPEG2,
>> @@ -90,6 +97,8 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V5PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION |
>> + V4L2_FMT_FLAG_CONTINUOUS_BYTESTREAM,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_MPEG4,
>> @@ -97,6 +106,8 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V5PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION |
>> + V4L2_FMT_FLAG_CONTINUOUS_BYTESTREAM,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_XVID,
>> @@ -104,6 +115,7 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V5PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_VC1_ANNEX_G,
>> @@ -111,6 +123,7 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V5PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_VC1_ANNEX_L,
>> @@ -118,6 +131,7 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V5PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_VP8,
>> @@ -125,6 +139,7 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V6PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_HEVC,
>> @@ -132,6 +147,8 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V10_BIT,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION |
>> + V4L2_FMT_FLAG_CONTINUOUS_BYTESTREAM,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_VP9,
>> @@ -139,6 +156,7 @@ static struct s5p_mfc_fmt formats[] = {
>> .type = MFC_FMT_DEC,
>> .num_planes = 1,
>> .versions = MFC_V10_BIT,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION,
>> },
>> };
>>
>> --
>> 2.20.1
>>
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2019-08-16 11:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 11:05 [PATCHv2 00/12] Stateful/stateless codec core support Hans Verkuil
2019-08-12 11:05 ` [PATCHv2 01/12] videodev2.h: add V4L2_FMT_FLAG_CONTINUOUS_BYTESTREAM Hans Verkuil
2019-08-14 12:52 ` Paul Kocialkowski
2019-08-15 8:11 ` Alexandre Courbot
2019-08-15 8:13 ` Alexandre Courbot
2019-08-12 11:05 ` [PATCHv2 02/12] videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION Hans Verkuil
2019-08-14 12:53 ` Paul Kocialkowski
2019-08-15 8:11 ` Alexandre Courbot
2019-08-15 10:09 ` Tomasz Figa
2019-08-15 14:22 ` Hans Verkuil
2019-08-12 11:05 ` [PATCHv2 03/12] media: venus: vdec: flag OUTPUT formats with V4L2_FMT_FLAG_DYN_RESOLUTION Hans Verkuil
2019-08-12 13:49 ` Stanimir Varbanov
2019-08-14 12:54 ` Paul Kocialkowski
2019-08-12 11:05 ` [PATCHv2 04/12] media: s5p_mfc_dec: set flags for OUTPUT coded formats Hans Verkuil
2019-08-14 12:55 ` Paul Kocialkowski
2019-08-15 10:14 ` Tomasz Figa
2019-08-16 11:37 ` Marek Szyprowski [this message]
2019-08-16 11:47 ` Tomasz Figa
2019-08-12 11:05 ` [PATCHv2 05/12] media: mtk-vcodec: flag OUTPUT formats with V4L2_FMT_FLAG_DYN_RESOLUTION Hans Verkuil
2019-08-14 12:59 ` Paul Kocialkowski
2019-08-15 8:12 ` Alexandre Courbot
2019-08-12 11:05 ` [PATCHv2 06/12] media: vicodec: set flags for vdec/stateful OUTPUT coded formats Hans Verkuil
2019-08-14 13:04 ` Paul Kocialkowski
2019-08-12 11:05 ` [PATCHv2 07/12] media: docs-rst: Document memory-to-memory video decoder interface Hans Verkuil
2019-08-12 11:05 ` [PATCHv2 08/12] pixfmt-compressed.rst: improve H264/HEVC/MPEG1+2/VP8+9 documentation Hans Verkuil
2019-08-14 13:09 ` Paul Kocialkowski
2019-08-14 13:15 ` Hans Verkuil
2019-08-12 11:05 ` [PATCHv2 09/12] vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF Hans Verkuil
2019-08-15 8:12 ` Alexandre Courbot
2019-08-15 11:53 ` Hans Verkuil
2019-08-15 12:27 ` Tomasz Figa
2019-08-15 12:31 ` Hans Verkuil
2019-08-15 14:27 ` Alexandre Courbot
2019-08-12 11:05 ` [PATCHv2 10/12] videodev2.h: add V4L2_DEC_CMD_FLUSH Hans Verkuil
2019-08-15 8:12 ` Alexandre Courbot
2019-08-15 11:53 ` Hans Verkuil
2019-08-12 11:05 ` [PATCHv2 11/12] media: docs-rst: Document m2m stateless video decoder interface Hans Verkuil
2019-08-15 9:58 ` Alexandre Courbot
2019-08-16 5:49 ` Alexandre Courbot
2019-08-16 6:59 ` Hans Verkuil
2019-08-16 7:17 ` Alexandre Courbot
2019-08-12 11:05 ` [PATCHv2 12/12] media: docs-rst: Document memory-to-memory video encoder interface Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563e44c1-afed-4b08-b7f9-ebe30c17d522@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=a.hajda@samsung.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jtp.park@samsung.com \
--cc=kamil@wypas.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=mjourdan@baylibre.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox