From: Hans Verkuil <hverkuil@xs4all.nl>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] v4l: Add YUV 4:2:2 and YUV 4:4:4 tri-planar non-contiguous formats
Date: Sat, 14 Nov 2015 14:50:40 +0100 [thread overview]
Message-ID: <56473C30.2090903@xs4all.nl> (raw)
In-Reply-To: <1447507593-15016-1-git-send-email-laurent.pinchart@ideasonboard.com>
On 11/14/2015 02:26 PM, Laurent Pinchart wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> The formats use three planes through the multiplanar API, allowing for
> non-contiguous planes in memory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> Documentation/DocBook/media/v4l/pixfmt-yuv422m.xml | 159 +++++++++++++++++++
> Documentation/DocBook/media/v4l/pixfmt-yuv444m.xml | 171 +++++++++++++++++++++
> Documentation/DocBook/media/v4l/pixfmt-yvu422m.xml | 159 +++++++++++++++++++
> Documentation/DocBook/media/v4l/pixfmt-yvu444m.xml | 171 +++++++++++++++++++++
> Documentation/DocBook/media/v4l/pixfmt.xml | 4 +
> drivers/media/v4l2-core/v4l2-ioctl.c | 4 +
> include/uapi/linux/videodev2.h | 4 +
> 7 files changed, 672 insertions(+)
> create mode 100644 Documentation/DocBook/media/v4l/pixfmt-yuv422m.xml
> create mode 100644 Documentation/DocBook/media/v4l/pixfmt-yuv444m.xml
> create mode 100644 Documentation/DocBook/media/v4l/pixfmt-yvu422m.xml
> create mode 100644 Documentation/DocBook/media/v4l/pixfmt-yvu444m.xml
>
> Hello,
>
> The driver using those formats should follow in the not too distant future,
> but I'd appreciate getting feedback on the definitions already.
Looks good, but I would combine yuv422m and yvu422m, and do the same for the 444m
variants. It's overkill to split this up.
>
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-yuv422m.xml b/Documentation/DocBook/media/v4l/pixfmt-yuv422m.xml
> new file mode 100644
> index 000000000000..f4d8d74e7f74
> --- /dev/null
> +++ b/Documentation/DocBook/media/v4l/pixfmt-yuv422m.xml
> @@ -0,0 +1,159 @@
> + <refentry id="V4L2-PIX-FMT-YUV422M">
> + <refmeta>
> + <refentrytitle>V4L2_PIX_FMT_YUV422M ('YM16')</refentrytitle>
> + &manvol;
> + </refmeta>
> + <refnamediv>
> + <refname> <constant>V4L2_PIX_FMT_YUV422M</constant></refname>
> + <refpurpose>Planar formats with ½ horizontal resolution, also
> + known as YUV 4:2:2</refpurpose>
> + </refnamediv>
> +
> + <refsect1>
> + <title>Description</title>
> +
> + <para>This is a multi-planar format, as opposed to a packed format.
> +The three components are separated into three sub- images or planes.
No space needed after 'sub-'.
Regards,
Hans
next prev parent reply other threads:[~2015-11-14 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 13:26 [PATCH] v4l: Add YUV 4:2:2 and YUV 4:4:4 tri-planar non-contiguous formats Laurent Pinchart
2015-11-14 13:50 ` Hans Verkuil [this message]
2016-01-11 3:09 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56473C30.2090903@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox