* [PATCH v3 10/10] media: flash: use led_set_brightness_sync for torch brightness [not found] <1444209048-29415-1-git-send-email-j.anaszewski@samsung.com> @ 2015-10-07 9:10 ` Jacek Anaszewski 2015-10-07 10:49 ` Pavel Machek 2015-11-16 9:35 ` Jacek Anaszewski 0 siblings, 2 replies; 6+ messages in thread From: Jacek Anaszewski @ 2015-10-07 9:10 UTC (permalink / raw) To: linux-leds Cc: linux-kernel, pavel, sakari.ailus, andrew, Jacek Anaszewski, linux-media LED subsystem shifted responsibility for choosing between SYNC or ASYNC way of setting brightness from drivers to the caller. Adapt the wrapper to those changes. Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> Cc: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: linux-media@vger.kernel.org --- drivers/media/v4l2-core/v4l2-flash-led-class.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-flash-led-class.c b/drivers/media/v4l2-core/v4l2-flash-led-class.c index 5bdfb8d..5d67335 100644 --- a/drivers/media/v4l2-core/v4l2-flash-led-class.c +++ b/drivers/media/v4l2-core/v4l2-flash-led-class.c @@ -107,10 +107,10 @@ static void v4l2_flash_set_led_brightness(struct v4l2_flash *v4l2_flash, if (ctrls[LED_MODE]->val != V4L2_FLASH_LED_MODE_TORCH) return; - led_set_brightness(&v4l2_flash->fled_cdev->led_cdev, + led_set_brightness_sync(&v4l2_flash->fled_cdev->led_cdev, brightness); } else { - led_set_brightness(&v4l2_flash->iled_cdev->led_cdev, + led_set_brightness_sync(&v4l2_flash->iled_cdev->led_cdev, brightness); } } @@ -206,11 +206,11 @@ static int v4l2_flash_s_ctrl(struct v4l2_ctrl *c) case V4L2_CID_FLASH_LED_MODE: switch (c->val) { case V4L2_FLASH_LED_MODE_NONE: - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness_sync(led_cdev, LED_OFF); return led_set_flash_strobe(fled_cdev, false); case V4L2_FLASH_LED_MODE_FLASH: /* Turn the torch LED off */ - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness_sync(led_cdev, LED_OFF); if (ctrls[STROBE_SOURCE]) { external_strobe = (ctrls[STROBE_SOURCE]->val == V4L2_FLASH_STROBE_SOURCE_EXTERNAL); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 10/10] media: flash: use led_set_brightness_sync for torch brightness 2015-10-07 9:10 ` [PATCH v3 10/10] media: flash: use led_set_brightness_sync for torch brightness Jacek Anaszewski @ 2015-10-07 10:49 ` Pavel Machek 2015-11-16 9:35 ` Jacek Anaszewski 1 sibling, 0 replies; 6+ messages in thread From: Pavel Machek @ 2015-10-07 10:49 UTC (permalink / raw) To: Jacek Anaszewski Cc: linux-leds, linux-kernel, sakari.ailus, andrew, linux-media On Wed 2015-10-07 11:10:48, Jacek Anaszewski wrote: > LED subsystem shifted responsibility for choosing between SYNC or ASYNC > way of setting brightness from drivers to the caller. Adapt the wrapper > to those changes. > > Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> 7-10 of the series: Acked-by: Pavel Machek <pavel@ucw.cz> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 10/10] media: flash: use led_set_brightness_sync for torch brightness 2015-10-07 9:10 ` [PATCH v3 10/10] media: flash: use led_set_brightness_sync for torch brightness Jacek Anaszewski 2015-10-07 10:49 ` Pavel Machek @ 2015-11-16 9:35 ` Jacek Anaszewski 2015-11-16 9:47 ` Sakari Ailus 1 sibling, 1 reply; 6+ messages in thread From: Jacek Anaszewski @ 2015-11-16 9:35 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: linux-leds, linux-kernel, pavel, sakari.ailus, andrew, linux-media Hi Mauro, This patch depends on the preceding LED core improvements patches from this patch set, and it would be best if it was merged through the LED tree. Can I get your ack for this? I've already obtained acks for the whole set from Sakari. Best Regards, Jacek Anaszewski On 10/07/2015 11:10 AM, Jacek Anaszewski wrote: > LED subsystem shifted responsibility for choosing between SYNC or ASYNC > way of setting brightness from drivers to the caller. Adapt the wrapper > to those changes. > > Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: linux-media@vger.kernel.org > --- > drivers/media/v4l2-core/v4l2-flash-led-class.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-flash-led-class.c b/drivers/media/v4l2-core/v4l2-flash-led-class.c > index 5bdfb8d..5d67335 100644 > --- a/drivers/media/v4l2-core/v4l2-flash-led-class.c > +++ b/drivers/media/v4l2-core/v4l2-flash-led-class.c > @@ -107,10 +107,10 @@ static void v4l2_flash_set_led_brightness(struct v4l2_flash *v4l2_flash, > if (ctrls[LED_MODE]->val != V4L2_FLASH_LED_MODE_TORCH) > return; > > - led_set_brightness(&v4l2_flash->fled_cdev->led_cdev, > + led_set_brightness_sync(&v4l2_flash->fled_cdev->led_cdev, > brightness); > } else { > - led_set_brightness(&v4l2_flash->iled_cdev->led_cdev, > + led_set_brightness_sync(&v4l2_flash->iled_cdev->led_cdev, > brightness); > } > } > @@ -206,11 +206,11 @@ static int v4l2_flash_s_ctrl(struct v4l2_ctrl *c) > case V4L2_CID_FLASH_LED_MODE: > switch (c->val) { > case V4L2_FLASH_LED_MODE_NONE: > - led_set_brightness(led_cdev, LED_OFF); > + led_set_brightness_sync(led_cdev, LED_OFF); > return led_set_flash_strobe(fled_cdev, false); > case V4L2_FLASH_LED_MODE_FLASH: > /* Turn the torch LED off */ > - led_set_brightness(led_cdev, LED_OFF); > + led_set_brightness_sync(led_cdev, LED_OFF); > if (ctrls[STROBE_SOURCE]) { > external_strobe = (ctrls[STROBE_SOURCE]->val == > V4L2_FLASH_STROBE_SOURCE_EXTERNAL); > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 10/10] media: flash: use led_set_brightness_sync for torch brightness 2015-11-16 9:35 ` Jacek Anaszewski @ 2015-11-16 9:47 ` Sakari Ailus 2015-11-16 13:34 ` Jacek Anaszewski 2015-12-03 13:35 ` Mauro Carvalho Chehab 0 siblings, 2 replies; 6+ messages in thread From: Sakari Ailus @ 2015-11-16 9:47 UTC (permalink / raw) To: Jacek Anaszewski, Mauro Carvalho Chehab Cc: linux-leds, linux-kernel, pavel, andrew, linux-media Jacek Anaszewski wrote: > This patch depends on the preceding LED core improvements patches > from this patch set, and it would be best if it was merged through > the LED tree. Can I get your ack for this? I've already obtained acks > for the whole set from Sakari. I agree with this going through the LED tree. -- Sakari Ailus sakari.ailus@linux.intel.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 10/10] media: flash: use led_set_brightness_sync for torch brightness 2015-11-16 9:47 ` Sakari Ailus @ 2015-11-16 13:34 ` Jacek Anaszewski 2015-12-03 13:35 ` Mauro Carvalho Chehab 1 sibling, 0 replies; 6+ messages in thread From: Jacek Anaszewski @ 2015-11-16 13:34 UTC (permalink / raw) To: Sakari Ailus Cc: Mauro Carvalho Chehab, linux-leds, linux-kernel, pavel, andrew, linux-media On 11/16/2015 10:47 AM, Sakari Ailus wrote: > Jacek Anaszewski wrote: >> This patch depends on the preceding LED core improvements patches >> from this patch set, and it would be best if it was merged through >> the LED tree. Can I get your ack for this? I've already obtained acks >> for the whole set from Sakari. > > I agree with this going through the LED tree. > Applied this patch set, with fixed version of the patch 4/10 [1], thanks. [1] http://www.spinics.net/lists/linux-leds/msg05045.html -- Best Regards, Jacek Anaszewski ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 10/10] media: flash: use led_set_brightness_sync for torch brightness 2015-11-16 9:47 ` Sakari Ailus 2015-11-16 13:34 ` Jacek Anaszewski @ 2015-12-03 13:35 ` Mauro Carvalho Chehab 1 sibling, 0 replies; 6+ messages in thread From: Mauro Carvalho Chehab @ 2015-12-03 13:35 UTC (permalink / raw) To: Sakari Ailus Cc: Jacek Anaszewski, linux-leds, linux-kernel, pavel, andrew, linux-media Em Mon, 16 Nov 2015 11:47:58 +0200 Sakari Ailus <sakari.ailus@linux.intel.com> escreveu: > Jacek Anaszewski wrote: > > This patch depends on the preceding LED core improvements patches > > from this patch set, and it would be best if it was merged through > > the LED tree. Can I get your ack for this? I've already obtained acks > > for the whole set from Sakari. > > I agree with this going through the LED tree. Feel free to send it via the LED tree. Acked-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> Regards, Mauro ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-03 13:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1444209048-29415-1-git-send-email-j.anaszewski@samsung.com>
2015-10-07 9:10 ` [PATCH v3 10/10] media: flash: use led_set_brightness_sync for torch brightness Jacek Anaszewski
2015-10-07 10:49 ` Pavel Machek
2015-11-16 9:35 ` Jacek Anaszewski
2015-11-16 9:47 ` Sakari Ailus
2015-11-16 13:34 ` Jacek Anaszewski
2015-12-03 13:35 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).