* [PATCH] staging: media: omap4iss: Constify platform_device_id
@ 2015-05-01 15:43 Krzysztof Kozlowski
2015-05-01 22:59 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2015-05-01 15:43 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman,
linux-media, devel, linux-kernel
Cc: Krzysztof Kozlowski
The platform_device_id is not modified by the driver and core uses it as
const.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
---
drivers/staging/media/omap4iss/iss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index e0ad5e520e2d..68867f286afd 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -1478,7 +1478,7 @@ static int iss_remove(struct platform_device *pdev)
return 0;
}
-static struct platform_device_id omap4iss_id_table[] = {
+static const struct platform_device_id omap4iss_id_table[] = {
{ "omap4iss", 0 },
{ },
};
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: omap4iss: Constify platform_device_id
2015-05-01 15:43 [PATCH] staging: media: omap4iss: Constify platform_device_id Krzysztof Kozlowski
@ 2015-05-01 22:59 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2015-05-01 22:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media, devel,
linux-kernel
Hi Krzysztof,
Thank you for the patch.
On Saturday 02 May 2015 00:43:07 Krzysztof Kozlowski wrote:
> The platform_device_id is not modified by the driver and core uses it as
> const.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree. I'll send a pull request for v4.2.
> ---
> drivers/staging/media/omap4iss/iss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c
> b/drivers/staging/media/omap4iss/iss.c index e0ad5e520e2d..68867f286afd
> 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -1478,7 +1478,7 @@ static int iss_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static struct platform_device_id omap4iss_id_table[] = {
> +static const struct platform_device_id omap4iss_id_table[] = {
> { "omap4iss", 0 },
> { },
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-01 22:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-01 15:43 [PATCH] staging: media: omap4iss: Constify platform_device_id Krzysztof Kozlowski
2015-05-01 22:59 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).