public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthias Schwarzott <zzam@gentoo.org>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-media@vger.kernel.org, crope@iki.fi, xpert-reactos@gmx.de
Subject: Re: [PATCH 07/10] si2165: Fix DVB-T bandwidth default
Date: Thu, 3 Dec 2015 21:11:08 +0100	[thread overview]
Message-ID: <5660A1DC.8050701@gentoo.org> (raw)
In-Reply-To: <20151203121524.33bd3130@recife.lan>

Am 03.12.2015 um 15:15 schrieb Mauro Carvalho Chehab:
> Em Thu, 19 Nov 2015 21:03:59 +0100
> Matthias Schwarzott <zzam@gentoo.org> escreveu:
> 
> 
> Please, add a description to your patches.
> 
> That's said, this patch should be called, instead:
> 
> si2165: Fix DVB-T bandwidth auto
> 
> DVB auto bandwidth mode (bandwidth_hz == 0) logic was setting
> the initial value for dvb_rate to a wrong value. Fix it.
> 
> as a zero value here means to let the frontend to auto-detect
> the bandwidth. Of course, assuming that si2165 is capable of
> doing that.
> 
> If si2165 chip or driver doesn't support bandwidth auto-detection, it
> should, instead, return -EINVAL.
> 
> Are you sure that it will auto-detect the bandwidth if we keep it
> as 8MHz?
> 

Thanks for the feedback.
As far as I know si2165 does not support auto-detection of bandwidth.

I only have 8MHz channels available I tried what happens when
configuring other bandwidth values - it will not lock.

So I will resend the modified the patch.

Regards
Matthias


  reply	other threads:[~2015-12-03 20:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 20:03 si2165: Add simple DVB-C support Matthias Schwarzott
2015-11-19 20:03 ` [PATCH 01/10] si2165: rename frontend -> fe Matthias Schwarzott
2015-11-19 20:03 ` [PATCH 02/10] si2165: rename si2165_set_parameters to si2165_set_frontend Matthias Schwarzott
2015-11-19 20:03 ` [PATCH 03/10] si2165: create function si2165_write_reg_list for writing register lists Matthias Schwarzott
2015-11-19 20:03 ` [PATCH 04/10] si2165: only write agc registers after reset before start_syncro Matthias Schwarzott
2015-11-19 20:03 ` [PATCH 05/10] si2165: move setting ts config to init Matthias Schwarzott
2015-11-19 20:03 ` [PATCH 06/10] si2165: Simplify si2165_set_if_freq_shift usage Matthias Schwarzott
2015-11-19 20:03 ` [PATCH 07/10] si2165: Fix DVB-T bandwidth default Matthias Schwarzott
2015-12-03 14:15   ` Mauro Carvalho Chehab
2015-12-03 20:11     ` Matthias Schwarzott [this message]
2015-12-03 20:12       ` [PATCH] si2165: Reject DVB-T bandwidth auto mode Matthias Schwarzott
2015-11-19 20:04 ` [PATCH 08/10] si2165: set list of DVB-T registers together Matthias Schwarzott
2015-11-19 20:04 ` [PATCH 09/10] si2165: Prepare si2165_set_frontend for splitting Matthias Schwarzott
2015-11-19 20:04 ` [PATCH 10/10] si2165: Add DVB-C support for HVR-4400/HVR-5500 Matthias Schwarzott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5660A1DC.8050701@gentoo.org \
    --to=zzam@gentoo.org \
    --cc=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=xpert-reactos@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox