From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25BDF1F12E9 for ; Tue, 24 Jun 2025 22:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750804878; cv=none; b=bYfBGi38ExwUCM3CwWvcERYnw9VEympeUZDMO0tNXNan+bMRh4iC4FqggOh3htG0JKrTUWPMcW31b6dls+NWiNQsEgSvlK3vBI/gLQgrYjBtyn8J72n39ioK2zRfivlZVIyLPRDEOGGijjiD+ssa4A0oqSkbfh31LlMo6OxqxIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750804878; c=relaxed/simple; bh=V5Q9WqOQIK17XMc/mdDR1DCpvbnuM76rJFm4WuVGyCo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RRu2zk26Yka/M5nqwdx9hH/Y59AZVhIMe0UObnuTQ+YPlA8JMZniY7hsvsNZ/M4VATfYd7VFqzujrAXu0+LYv/ArAKNk9rJ1benT/IyZV5/+Hy1uprlyth31Y3RCNgtUpLlcGc4VVp+pKzLnrFCC/UMZyPXpGH2gKJE2GAQ77NY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=QtSejHk4; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="QtSejHk4" Received: from [192.168.0.43] (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DB8D982; Wed, 25 Jun 2025 00:40:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1750804856; bh=V5Q9WqOQIK17XMc/mdDR1DCpvbnuM76rJFm4WuVGyCo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QtSejHk4uxivKkWJ+lBtBN2fD8eDwxFkjzKOmf3dU7SO3QQ/GdG9G+cElrH9BWTcp aGxNOXutH5s17HINjrb7ydVbDUOGLReasak2BC+JFjLyWORXGD062epiLG/3HrDjgz ikLxlVsjfAWLY4sVR+cCPruotzf/cFhPJnTkMPQ0= Message-ID: <566b04aa-b2d5-4c42-9b7e-9f7a8a1e6b8a@ideasonboard.com> Date: Tue, 24 Jun 2025 23:41:10 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/6] media: v4l2: Add Renesas Camera Receiver Unit pixel formats To: Laurent Pinchart , Sakari Ailus Cc: linux-media@vger.kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com, jacopo.mondi@ideasonboard.com, Hans Verkuil , Daniel Scally References: <20250623-rzg2l-cru-v5-0-1663a8c6719a@ideasonboard.com> <20250623-rzg2l-cru-v5-1-1663a8c6719a@ideasonboard.com> <20250624152033.GA20757@pendragon.ideasonboard.com> <20250624220250.GH20757@pendragon.ideasonboard.com> Content-Language: en-US From: Dan Scally Autocrypt: addr=dan.scally@ideasonboard.com; keydata= xsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW B31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove eIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq MHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX sUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU RWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1 NTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf vzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl 1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33 u4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5 IDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe kiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2 EAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg cEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm w/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi HSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7 c0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ nhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh AiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6 9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y ejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj xjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x xHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC PJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16 tPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t 8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp hyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT +49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj JwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX xGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K aL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL a/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT BQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM Res4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp vjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC FHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR du90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy xBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901 D+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM yMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt 9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1 u1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC In-Reply-To: <20250624220250.GH20757@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Laurent, Sakari On 24/06/2025 23:02, Laurent Pinchart wrote: > On Tue, Jun 24, 2025 at 09:35:04PM +0000, Sakari Ailus wrote: >> On Tue, Jun 24, 2025 at 06:20:33PM +0300, Laurent Pinchart wrote: >>> On Tue, Jun 24, 2025 at 10:25:19AM +0000, Sakari Ailus wrote: >>>> On Mon, Jun 23, 2025 at 03:43:18PM +0100, Daniel Scally wrote: >>>>> From: Daniel Scally >>>>> >>>>> The Renesas Camera Receiver Unit in the RZ/V2H SoC can output RAW >>>>> data captured from an image sensor without conversion to an RGB/YUV >>>>> format. In that case the data are packed into 64-bit blocks, with a >>>>> variable amount of padding in the most significant bits depending on >>>>> the bitdepth of the data. Add new V4L2 pixel format codes for the new >>>>> formats, along with documentation to describe them. >>>>> >>>>> Reviewed-by: Lad Prabhakar >>>>> Reviewed-by: Laurent Pinchart >>>>> Reviewed-by: Jacopo Mondi >>>>> Signed-off-by: Daniel Scally >>>>> --- >>>>> Changes in v5: >>>>> >>>>> - None >>>>> >>>>> Changes in v4: >>>>> >>>>> - Removed references to "Bayer" or "srgb" >>>>> >>>>> Changes in v3: >>>>> >>>>> - Switched from bayer-order specific formats to generic RAWnn >>>>> >>>>> Changes in v2: >>>>> >>>>> - Added labels to the new formats in the documentation file >>>>> - Added 20-bit formats >>>>> --- >>>>> .../userspace-api/media/v4l/pixfmt-bayer.rst | 1 + >>>>> .../userspace-api/media/v4l/pixfmt-rawnn-cru.rst | 143 +++++++++++++++++++++ >>>>> drivers/media/v4l2-core/v4l2-common.c | 6 + >>>>> drivers/media/v4l2-core/v4l2-ioctl.c | 4 + >>>>> include/uapi/linux/videodev2.h | 6 + >>>>> 5 files changed, 160 insertions(+) >>>>> >>>>> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-bayer.rst b/Documentation/userspace-api/media/v4l/pixfmt-bayer.rst >>>>> index ed3eb432967d9845d3d65150831d8a7f62dec994..20a8aa04330479ed4d44c8e4fc3d57db8c2e6933 100644 >>>>> --- a/Documentation/userspace-api/media/v4l/pixfmt-bayer.rst >>>>> +++ b/Documentation/userspace-api/media/v4l/pixfmt-bayer.rst >>>>> @@ -31,3 +31,4 @@ orders. See also `the Wikipedia article on Bayer filter >>>>> pixfmt-srggb14 >>>>> pixfmt-srggb14p >>>>> pixfmt-srggb16 >>>>> + pixfmt-rawnn-cru >>>>> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-rawnn-cru.rst b/Documentation/userspace-api/media/v4l/pixfmt-rawnn-cru.rst >>>>> new file mode 100644 >>>>> index 0000000000000000000000000000000000000000..d786833d0cf355b3955fe63d85c8a211a7a4fb23 >>>>> --- /dev/null >>>>> +++ b/Documentation/userspace-api/media/v4l/pixfmt-rawnn-cru.rst >>>>> @@ -0,0 +1,143 @@ >>>>> +.. SPDX-License-Identifier: GFDL-1.1-no-invariants-or-later >>>>> + >>>>> +.. _v4l2-pix-fmt-cru-raw10: >>>>> +.. _v4l2-pix-fmt-cru-raw12: >>>>> +.. _v4l2-pix-fmt-cru-raw14: >>>>> +.. _v4l2-pix-fmt-cru-raw20: >>>>> + >>>>> +********************************************************************************************************************************** >>>>> +V4L2_PIX_FMT_CRU_RAW10 ('CR10'), V4L2_PIX_FMT_CRU_RAW12 ('CR12'), V4L2_PIX_FMT_CRU_RAW14 ('CR14'), V4L2_PIX_FMT_CRU_RAW20 ('CR20') >>>>> +********************************************************************************************************************************** >>>> Regarding naming, could these be called V4L2_PIX_FMT_RAW_CRUxx, to align >>>> the naming with the new raw formats? >>>> >>>> >>>> If you rebase on the metadata series, I can pick this patch in the set. My >>>> objective is to get this merged in this cycle, which of course also depends >>>> on review feedback. >>> Your set is big enough :-) >>> >>> Unless I'm missing something, this patch doesn't depend on the metadata >>> series. I plan to pick up Dan's next version (with the formats renamed) >>> and send a pull request. >> That works, too. I believe people are generally happy with the approach of >> conveying the color pattern. But you still need the metadata series for >> these to work I suppose? > Not with this patch series, as far as I can tell. No; I'm not using the metadata series - this works without it. > >> Do you btw. intend to use these in conjunction with the usual Bayer mbus >> codes? It might be useful to have helpers for this purpose but we could add >> them later on (and probably not just for that). > See patch 6/6, the regularo bayer media bus codes are used with these > pixel formats. Indeed > Ideally I'd ditch the bayer media bus codes and use the raw media bus > codes, but those are not in mainline yet. It would add a dependency on > the metadata series. >