From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:42952 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754066Ab2JDWKS (ORCPT ); Thu, 4 Oct 2012 18:10:18 -0400 From: Laurent Pinchart To: Prabhakar Cc: LMML , DLOS , Manjunath Hadli , VGER , LDOC , "Lad, Prabhakar" , Sakari Ailus , Guennadi Liakhovetski , Sylwester Nawrocki , Hans Verkuil , Rob Landley , Mauro Carvalho Chehab Subject: Re: [PATCH RFC] media: v4l2-ctrl: Add digital gain controls Date: Fri, 05 Oct 2012 00:10:59 +0200 Message-ID: <5672168.aGSCLrPrvl@avalon> In-Reply-To: <1349100219-7599-1-git-send-email-prabhakar.lad@ti.com> References: <1349100219-7599-1-git-send-email-prabhakar.lad@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Prabhakar, Thanks for the patch. On Monday 01 October 2012 19:33:39 Prabhakar wrote: > From: Lad, Prabhakar > > add support for per color component digital gain controls > and also their corresponding offset. > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > Cc: Sakari Ailus > Cc: Laurent Pinchart > Cc: Guennadi Liakhovetski > Cc: Sylwester Nawrocki > Cc: Hans Verkuil > Cc: Hans de Goede hdegoede@redhat.com > Cc: Chris MacGregor chris@cybermato.com > Cc: Rob Landley > Cc: Mauro Carvalho Chehab > --- > Documentation/DocBook/media/v4l/controls.xml | 54 +++++++++++++++++++++++ > drivers/media/v4l2-core/v4l2-ctrls.c | 11 +++++ > include/linux/v4l2-controls.h | 11 +++++ > 3 files changed, 76 insertions(+), 0 deletions(-) > > diff --git a/Documentation/DocBook/media/v4l/controls.xml > b/Documentation/DocBook/media/v4l/controls.xml index a84a08c..9bf54f3 > 100644 > --- a/Documentation/DocBook/media/v4l/controls.xml > +++ b/Documentation/DocBook/media/v4l/controls.xml > @@ -4277,6 +4277,60 @@ interface and may change in the future. > specific test patterns can be used to test if a device is working > properly. > > + > + V4L2_CID_GAIN_RED > + integer > + > + > + spanname="id">V4L2_CID_GAIN_GREEN_RED + > integer > + > + > + spanname="id">V4L2_CID_GAIN_GREEN_BLUE + > integer > + > + > + V4L2_CID_GAIN_BLUE > + integer > + > + > + V4L2_CID_GAIN_GREEN > + integer > + > + > + Some capture/sensor devices have > + the capability to set per color component digital gain values. > + > + > + V4L2_CID_GAIN_OFFSET > + integer > + > + > + V4L2_CID_BLUE_OFFSET > + integer > + > + > + V4L2_CID_RED_OFFSET > + integer > + > + > + spanname="id">V4L2_CID_GREEN_OFFSET + > integer > + > + > + spanname="id">V4L2_CID_GREEN_RED_OFFSET + > integer > + > + > + spanname="id">V4L2_CID_GREEN_BLUE_OFFSET + > integer > + > + > + Some capture/sensor devices have the > + capability to set per color component digital gain offset values. > + V4L2_CID_GAIN_OFFSET is the global gain offset and the rest are per > + color component gain offsets. > + > > > > diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c > b/drivers/media/v4l2-core/v4l2-ctrls.c index 93cd0a4..02cc1d2 100644 > --- a/drivers/media/v4l2-core/v4l2-ctrls.c > +++ b/drivers/media/v4l2-core/v4l2-ctrls.c > @@ -750,6 +750,17 @@ const char *v4l2_ctrl_get_name(u32 id) > case V4L2_CID_LINK_FREQ: return "Link Frequency"; > case V4L2_CID_PIXEL_RATE: return "Pixel Rate"; > case V4L2_CID_TEST_PATTERN: return "Test Pattern"; > + case V4L2_CID_GAIN_RED: return "Digital Gain Red"; > + case V4L2_CID_GAIN_GREEN_RED: return "Digital Gain Green Red"; > + case V4L2_CID_GAIN_GREEN_BLUE: return "Digital Gain Green Blue"; > + case V4L2_CID_GAIN_BLUE: return "Digital Gain Blue"; > + case V4L2_CID_GAIN_GREEN: return "Digital Gain Green"; > + case V4L2_CID_GAIN_OFFSET: return "Digital Gain Offset"; > + case V4L2_CID_BLUE_OFFSET: return "Digital Gain Blue Offset"; > + case V4L2_CID_RED_OFFSET: return "Digital Gain Red Offset"; > + case V4L2_CID_GREEN_OFFSET: return "Digital Gain Green Offset"; > + case V4L2_CID_GREEN_RED_OFFSET: return "Digital Gain Green Red Offset"; > + case V4L2_CID_GREEN_BLUE_OFFSET: return "Digital Gain Green Blue Offset"; I would remove the mention of "Digital" here, as those controls can be used for analog gains as well. Same above in the documentation. > /* DV controls */ > case V4L2_CID_DV_CLASS: return "Digital Video Controls"; > diff --git a/include/linux/v4l2-controls.h b/include/linux/v4l2-controls.h > index e1b3680..087596d 100644 > --- a/include/linux/v4l2-controls.h > +++ b/include/linux/v4l2-controls.h > @@ -758,5 +758,16 @@ enum v4l2_jpeg_chroma_subsampling { > #define V4L2_CID_LINK_FREQ (V4L2_CID_IMAGE_PROC_CLASS_BASE + 1) > #define V4L2_CID_PIXEL_RATE (V4L2_CID_IMAGE_PROC_CLASS_BASE + 2) > #define V4L2_CID_TEST_PATTERN (V4L2_CID_IMAGE_PROC_CLASS_BASE + 3) > +#define V4L2_CID_GAIN_RED (V4L2_CID_IMAGE_PROC_CLASS_BASE + 4) > +#define V4L2_CID_GAIN_GREEN_RED (V4L2_CID_IMAGE_PROC_CLASS_BASE + 5) > +#define V4L2_CID_GAIN_GREEN_BLUE (V4L2_CID_IMAGE_PROC_CLASS_BASE + 6) > +#define V4L2_CID_GAIN_BLUE (V4L2_CID_IMAGE_PROC_CLASS_BASE + 7) > +#define V4L2_CID_GAIN_GREEN (V4L2_CID_IMAGE_PROC_CLASS_BASE + 8) > +#define V4L2_CID_GAIN_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 9) > +#define V4L2_CID_BLUE_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 10) > +#define V4L2_CID_RED_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 11) > +#define V4L2_CID_GREEN_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 12) > +#define V4L2_CID_GREEN_RED_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 13) > +#define V4L2_CID_GREEN_BLUE_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 14) > > #endif -- Regards, Laurent Pinchart