From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf0-f49.google.com ([209.85.215.49]:33777 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281AbbL0LSs (ORCPT ); Sun, 27 Dec 2015 06:18:48 -0500 Received: by mail-lf0-f49.google.com with SMTP id p203so189185591lfa.0 for ; Sun, 27 Dec 2015 03:18:47 -0800 (PST) Subject: Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq To: Julia Lawall References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> <567EF188.7020203@cogentembedded.com> <567EF895.6080702@cogentembedded.com> <567F141C.8010000@cogentembedded.com> <567F166B.7030208@cogentembedded.com> Cc: Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org From: Sergei Shtylyov Message-ID: <567FC914.4080705@cogentembedded.com> Date: Sun, 27 Dec 2015 14:18:44 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 12/27/2015 9:13 AM, Julia Lawall wrote: >> Well, looking again, the patch should be good. I just thought its goal was >> to fix the code as well... > > I could do that for the irq < 0 case, but I think that in that case, kbuild > will only run the patch version, and the <= cases will not be reported on. > I don't have a general fix for the <= 0. Is it even correct to have < in > some cases and <= in others? That's a good question... In my prior fixes of this case I preferred to consider IRQ0 valid and so used 'irq < 0'. I myself don't share the "IRQ0 is invalid" sentiment... > julia MBR, Sergei