* [PATCH] media: rc: core: simplify DEFINE_IR_RAW_EVENT
@ 2015-12-30 12:24 Heiner Kallweit
0 siblings, 0 replies; only message in thread
From: Heiner Kallweit @ 2015-12-30 12:24 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media
DEFINE_IR_RAW_EVENT can be simplified and doesn't provide much benefit
as all elements are initialized to 0. But keep it as it is used in a
lot of places.
duration is the first element of the embedded union and therefore
used for the initialization even if not explicitely mentioned.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
include/media/rc-core.h | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/include/media/rc-core.h b/include/media/rc-core.h
index f649470..91c6633 100644
--- a/include/media/rc-core.h
+++ b/include/media/rc-core.h
@@ -226,13 +226,7 @@ struct ir_raw_event {
unsigned carrier_report:1;
};
-#define DEFINE_IR_RAW_EVENT(event) \
- struct ir_raw_event event = { \
- { .duration = 0 } , \
- .pulse = 0, \
- .reset = 0, \
- .timeout = 0, \
- .carrier_report = 0 }
+#define DEFINE_IR_RAW_EVENT(event) struct ir_raw_event event = {}
static inline void init_ir_raw_event(struct ir_raw_event *ev)
{
@@ -254,8 +248,7 @@ void ir_raw_event_set_idle(struct rc_dev *dev, bool idle);
static inline void ir_raw_event_reset(struct rc_dev *dev)
{
- DEFINE_IR_RAW_EVENT(ev);
- ev.reset = true;
+ struct ir_raw_event ev = { .reset = true };
ir_raw_event_store(dev, &ev);
ir_raw_event_handle(dev);
--
2.6.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-12-30 12:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-30 12:24 [PATCH] media: rc: core: simplify DEFINE_IR_RAW_EVENT Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).