From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:32161 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbcAMOgn (ORCPT ); Wed, 13 Jan 2016 09:36:43 -0500 Subject: Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA To: Sakari Ailus , Sudip Mukherjee References: <1451481963-18853-1-git-send-email-sudipm.mukherjee@gmail.com> <20160111125310.GA19742@sudip-pc> <20160112141042.GI576@valkosipuli.retiisi.org.uk> Cc: Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Andrew Morton , hverkuil@xs4all.nl, pawel@osciak.com, kyungmin.park@samsung.com From: Marek Szyprowski Message-id: <569660F7.2000802@samsung.com> Date: Wed, 13 Jan 2016 15:36:39 +0100 MIME-version: 1.0 In-reply-to: <20160112141042.GI576@valkosipuli.retiisi.org.uk> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello, On 2016-01-12 15:10, Sakari Ailus wrote: > On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote: >> On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote: >>> The build of m32r allmodconfig fails with the error: >>> drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2: >>> error: implicit declaration of function 'dma_get_cache_alignment' >>> >>> The build of videobuf2-dma-contig.c depends on HAS_DMA and it is >>> correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also >>> selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile >>> videobuf2-dma-contig.c even though HAS_DMA is not defined. >>> >>> Signed-off-by: Sudip Mukherjee >>> --- >> A gentle ping. m32r allmodconfig still fails with next-20160111. Build >> log is at: >> https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379 > Hi Sudip, > > Even though the issue now manifests itself on m32r, the problem is wider > than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is > set. > > I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is > disabled, so perhaps it'd be possible to make it depend on HAS_DMA. VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies are not checked further. This is known limitation/feature of kconfig system. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland