From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb2-smtp-cloud2.xs4all.net ([194.109.24.25]:57561 "EHLO lb2-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755836AbcAOIeK (ORCPT ); Fri, 15 Jan 2016 03:34:10 -0500 Subject: Re: [RESEND PATCH v2] media: v4l2-compat-ioctl32: fix missing length copy in put_v4l2_buffer32 To: Tiffany Lin , Mauro Carvalho Chehab References: <1452828517-57392-1-git-send-email-tiffany.lin@mediatek.com> Cc: Eddie Huang , Yingjoe Chen , linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org From: Hans Verkuil Message-ID: <5698AEF7.5090003@xs4all.nl> Date: Fri, 15 Jan 2016 09:33:59 +0100 MIME-Version: 1.0 In-Reply-To: <1452828517-57392-1-git-send-email-tiffany.lin@mediatek.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 01/15/2016 04:28 AM, Tiffany Lin wrote: > In v4l2-compliance utility, test QUERYBUF required correct length > value to go through each planar to check planar's length in > multi-planar buffer type > > Signed-off-by: Tiffany Lin > --- > Remove "Change-Id: I98faddc5711c24f17beda52e6d18c657add251ac" > --- > > drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c > index 327e83a..6c01920 100644 > --- a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c > +++ b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c > @@ -516,6 +516,9 @@ static int put_v4l2_buffer32(struct v4l2_buffer *kp, struct v4l2_buffer32 __user > put_user(kp->reserved, &up->reserved)) > return -EFAULT; > > + if (put_user(kp->length, &up->length)) > + return -EFAULT; > + This should also be done for get_v4l2_buffer32, and the other places where length is used in put/get_user() can now be removed. Regards, Hans > if (V4L2_TYPE_IS_MULTIPLANAR(kp->type)) { > num_planes = kp->length; > if (num_planes == 0) >