Re: [v4l-utils PATCH v2 2/3] libv4l2subdev: Add a function to list library supported pixel codes

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Laurent,

Laurent Pinchart wrote:
> Hi Sakari,
> 
> Thank you for the patch.
> 
> On Tuesday 08 December 2015 17:15:15 Sakari Ailus wrote:
>> Also mark which format definitions are compat definitions for the
>> pre-existing codes. This way we don't end up listing the same formats
>> twice.
> 
> Wouldn't it be easier to add a function to return the whole array (and 
> terminate it with an empty entry to avoid having to return both the array and 
> the length=) ?

Now that I'm actually thinking about making that change, I have a few
concerns:

- This is not in line with the other APIs in the library, they mirror
the IOCTL behaviour (it's another debate whether this is a good idea or
not).

- I need a new statically allocated array for that. I think I'll change
my sed script. Allocating an array when the function is called the first
time isn't a great idea either, there's a problem with re-entrancy and
it's a memory leak, too.

So don't complain about these when I send an updated version. ;-)

-- 
Cheers,

Sakari Ailus
sakari.ailus@linux.intel.com