Re: [PATCH] media: Support Intersil/Techwell TW686x-based video capture cards

Ezequiel Garcia
2016-01-26T12:35:28Z

On 26 January 2016 at 08:16, Krzysztof Hałasa <khalasa@piap.pl> wrote:
> Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
>
>> Well, I plan to add SG mode as soon as this driver is merged, so hopefully you
>> won't have to use an out of tree driver anymore.
>
> So why don't you want to do it the normal way, i.e., add your specific
> changes on top of my driver?
>

As far as I can see, you sent a driver back in July:

https://patchwork.linuxtv.org/patch/30448/

I reviewed the driver as soon as it was sent, and planned to submit
changes to support my setup once your driver was merged, but that
never happened.

Since you never submitted a v2, I sincerely thought that after six
months you had lost the interest.
There is no "your" driver vs. "my" driver, it's the same driver, as
the copyright note explains.

> This way you don't have to add SG mode. It's already there. Also, this
> means I (and others) don't have to hope. And, your changes can be much
> better examined, bisected etc.
>
> For now, there is no in-tree driver, all versions are out of tree.
>
> At the moment, from my POV it all looks this way:
> - I have written a driver and posted it for inclusion
> - it works on my systems, complies with the LK, V4L standards etc.,
> though it probably still needs some small changes
> - you took it, (I guess) added the needed changes (and others), removed
> the critical functionality, and want it merged instead of the
> original, working version.
>
> I can only see two ways out ( which make sense) from this. The first is:
> we add my driver first and then your specific changes on top of it.
>

If you want your driver merged, then you would have to submit it
again, addressing
my review comments. However, I have just posted a v2 and it would be nice if
you can review it and test it.

Thanks,
--
Ezequiel García, VanguardiaSur