Re: [PATCH] media: Support Intersil/Techwell TW686x-based video capture cards

Krzysztof Hałasa
2016-01-26T11:16:33Z

Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:

> Well, I plan to add SG mode as soon as this driver is merged, so hopefully you
> won't have to use an out of tree driver anymore.

So why don't you want to do it the normal way, i.e., add your specific
changes on top of my driver?

This way you don't have to add SG mode. It's already there. Also, this
means I (and others) don't have to hope. And, your changes can be much
better examined, bisected etc.

For now, there is no in-tree driver, all versions are out of tree.

At the moment, from my POV it all looks this way:
- I have written a driver and posted it for inclusion
- it works on my systems, complies with the LK, V4L standards etc.,
though it probably still needs some small changes
- you took it, (I guess) added the needed changes (and others), removed
the critical functionality, and want it merged instead of the
original, working version.

I can only see two ways out (which make sense) from this. The first is:
we add my driver first and then your specific changes on top of it.

The other one: I add required changes (e.g. the one that sets default
mode on start, or something alike, I don't remember exactly) and then we
add the driver. Then I'll also add the non-SG CMA DMA frame and field
mode (DMA to buffers), since it seems I will need it (and it was a bit
overlooked).
--
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland