From: Hans Verkuil <hverkuil@xs4all.nl>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
no To-header on input <""@pop.xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 06/11] [media] v4l2-mc: use usb_make_path() to provide bus info
Date: Fri, 12 Feb 2016 10:55:45 +0100 [thread overview]
Message-ID: <56BDAC21.9000005@xs4all.nl> (raw)
In-Reply-To: <9b8fed2b73514df87fced36481f84a0a745b674d.1455269986.git.mchehab@osg.samsung.com>
On 02/12/2016 10:45 AM, Mauro Carvalho Chehab wrote:
> Report the bus info on the same way as VIDIOC_QUERYCAP. Also,
> currently, it is reporting just PORT/DEV.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> ---
> drivers/media/v4l2-core/v4l2-mc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c
> index 649972e87621..ab5e42a86cc5 100644
> --- a/drivers/media/v4l2-core/v4l2-mc.c
> +++ b/drivers/media/v4l2-core/v4l2-mc.c
> @@ -79,7 +79,7 @@ struct media_device * __v4l2_mc_usb_media_device_init(struct usb_device *udev,
> strlcpy(mdev->model, "unknown model", sizeof(mdev->model));
> if (udev->serial)
> strlcpy(mdev->serial, udev->serial, sizeof(mdev->serial));
> - strcpy(mdev->bus_info, udev->devpath);
> + usb_make_path(udev, mdev->bus_info, sizeof(mdev->bus_info));
> mdev->hw_revision = le16_to_cpu(udev->descriptor.bcdDevice);
> mdev->driver_version = LINUX_VERSION_CODE;
>
>
Please fold this in patch 02/11 and you can disregard my comment about
strcpy vs strlcpy.
Regards,
Hans
next prev parent reply other threads:[~2016-02-12 9:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 9:44 [PATCH 00/11] Some improvements/fixes Mauro Carvalho Chehab
2016-02-12 9:44 ` [PATCH 01/11] [media] v4l2-mc.h: prevent it for being included twice Mauro Carvalho Chehab
2016-02-12 9:50 ` Hans Verkuil
2016-02-12 9:44 ` [PATCH 02/11] [media] v4l2-mc: add a routine to create USB media_device Mauro Carvalho Chehab
2016-02-12 9:52 ` Hans Verkuil
2016-02-12 9:44 ` [PATCH 03/11] [media] rc-core: don't lock device at rc_register_device() Mauro Carvalho Chehab
2016-02-12 9:44 ` [PATCH 04/11] [media] allow overriding the driver name Mauro Carvalho Chehab
2016-02-12 9:45 ` [PATCH 05/11] [media] use v4l2_mc_usb_media_device_init() on most USB devices Mauro Carvalho Chehab
2016-02-12 9:45 ` [PATCH 06/11] [media] v4l2-mc: use usb_make_path() to provide bus info Mauro Carvalho Chehab
2016-02-12 9:55 ` Hans Verkuil [this message]
2016-02-12 9:45 ` [PATCH 07/11] [media] em28xx-dvb: create RF connector on DVB-only mode Mauro Carvalho Chehab
2016-02-12 9:45 ` [PATCH 08/11] [media] cx231xx: use v4l2 core function to create the MC graph Mauro Carvalho Chehab
2016-02-12 10:40 ` kbuild test robot
2016-02-12 9:45 ` [PATCH 09/11] [media] si2157: register as a tuner entity Mauro Carvalho Chehab
2016-02-12 9:45 ` [PATCH 10/11] [media] cx231xx, em28xx: pass media_device to si2157 Mauro Carvalho Chehab
2016-02-12 9:45 ` [PATCH 11/11] [media] cx231xx: create connectors at the media graph Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BDAC21.9000005@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox