public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	no To-header on input <""@pop.xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Scott Jiang <scott.jiang.linux@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Tommi Rantala <tt.rantala@gmail.com>,
	Olli Salonen <olli.salonen@iki.fi>
Subject: Re: [PATCH 2/2] [media] cx231xx: get rid of CX231XX_VMUX_DEBUG
Date: Fri, 12 Feb 2016 13:16:19 +0100	[thread overview]
Message-ID: <56BDCD13.9070606@xs4all.nl> (raw)
In-Reply-To: <74a125ed2542ac0306e8582bc86dd0fc9a2bdc02.1455276050.git.mchehab@osg.samsung.com>

On 02/12/2016 12:21 PM, Mauro Carvalho Chehab wrote:
> This macro is not used inside the driver. get rid of it.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

> ---
>  drivers/media/usb/cx231xx/cx231xx-video.c | 3 +--
>  drivers/media/usb/cx231xx/cx231xx.h       | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c b/drivers/media/usb/cx231xx/cx231xx-video.c
> index 7222b1c27d40..6414188ffdfa 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-video.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-video.c
> @@ -1103,7 +1103,6 @@ static const char *iname[] = {
>  	[CX231XX_VMUX_TELEVISION] = "Television",
>  	[CX231XX_VMUX_CABLE]      = "Cable TV",
>  	[CX231XX_VMUX_DVB]        = "DVB",
> -	[CX231XX_VMUX_DEBUG]      = "for debug only",
>  };
>  
>  void cx231xx_v4l2_create_entities(struct cx231xx *dev)
> @@ -1136,7 +1135,7 @@ void cx231xx_v4l2_create_entities(struct cx231xx *dev)
>  			if (dev->tuner_type == TUNER_ABSENT)
>  				continue;
>  			/* fall though */
> -		default: /* CX231XX_VMUX_DEBUG */
> +		default: /* just to shut up a gcc warning */
>  			ent->function = MEDIA_ENT_F_CONN_RF;
>  			break;
>  		}
> diff --git a/drivers/media/usb/cx231xx/cx231xx.h b/drivers/media/usb/cx231xx/cx231xx.h
> index 60e14776a6cd..69f6d20870f5 100644
> --- a/drivers/media/usb/cx231xx/cx231xx.h
> +++ b/drivers/media/usb/cx231xx/cx231xx.h
> @@ -281,7 +281,6 @@ enum cx231xx_itype {
>  	CX231XX_VMUX_CABLE,
>  	CX231XX_RADIO,
>  	CX231XX_VMUX_DVB,
> -	CX231XX_VMUX_DEBUG
>  };
>  
>  enum cx231xx_v_input {
> 


  reply	other threads:[~2016-02-12 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12 11:21 [PATCH 1/2] [media] au0828: get rid of AU0828_VMUX_DEBUG Mauro Carvalho Chehab
2016-02-12 11:21 ` [PATCH 2/2] [media] cx231xx: get rid of CX231XX_VMUX_DEBUG Mauro Carvalho Chehab
2016-02-12 12:16   ` Hans Verkuil [this message]
2016-02-12 12:16 ` [PATCH 1/2] [media] au0828: get rid of AU0828_VMUX_DEBUG Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BDCD13.9070606@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=a.hajda@samsung.com \
    --cc=arnd@arndb.de \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mchehab@osg.samsung.com \
    --cc=olli.salonen@iki.fi \
    --cc=prabhakar.csengg@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=scott.jiang.linux@gmail.com \
    --cc=tt.rantala@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox