* [PATCH] media-device.h: fix compiler warning
@ 2016-02-26 7:44 Hans Verkuil
2016-03-02 7:54 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2016-02-26 7:44 UTC (permalink / raw)
To: Linux Media Mailing List
Fix these compiler warnings:
media-git/include/media/media-device.h: In function 'media_device_pci_init':
media-git/include/media/media-device.h:610:9: warning: 'return' with a value, in function returning void
return NULL;
^
media-git/include/media/media-device.h: In function '__media_device_usb_init':
media-git/include/media/media-device.h:618:9: warning: 'return' with a value, in function returning void
return NULL;
^
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
diff --git a/include/media/media-device.h b/include/media/media-device.h
index 49dda6c..44012fe 100644
--- a/include/media/media-device.h
+++ b/include/media/media-device.h
@@ -607,7 +607,6 @@ static inline void media_device_pci_init(struct media_device *mdev,
struct pci_dev *pci_dev,
char *name)
{
- return NULL;
}
static inline void __media_device_usb_init(struct media_device *mdev,
@@ -615,7 +614,6 @@ static inline void __media_device_usb_init(struct media_device *mdev,
char *board_name,
char *driver_name)
{
- return NULL;
}
#endif /* CONFIG_MEDIA_CONTROLLER */
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media-device.h: fix compiler warning
2016-02-26 7:44 [PATCH] media-device.h: fix compiler warning Hans Verkuil
@ 2016-03-02 7:54 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2016-03-02 7:54 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
Hi Hans,
Thank you for the patch.
On Friday 26 February 2016 08:44:35 Hans Verkuil wrote:
> Fix these compiler warnings:
>
> media-git/include/media/media-device.h: In function 'media_device_pci_init':
> media-git/include/media/media-device.h:610:9: warning: 'return' with a
> value, in function returning void return NULL;
> ^
> media-git/include/media/media-device.h: In function
> '__media_device_usb_init': media-git/include/media/media-device.h:618:9:
> warning: 'return' with a value, in function returning void return NULL;
> ^
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> diff --git a/include/media/media-device.h b/include/media/media-device.h
> index 49dda6c..44012fe 100644
> --- a/include/media/media-device.h
> +++ b/include/media/media-device.h
> @@ -607,7 +607,6 @@ static inline void media_device_pci_init(struct
> media_device *mdev, struct pci_dev *pci_dev,
> char *name)
> {
> - return NULL;
> }
>
> static inline void __media_device_usb_init(struct media_device *mdev,
> @@ -615,7 +614,6 @@ static inline void __media_device_usb_init(struct
> media_device *mdev, char *board_name,
> char *driver_name)
> {
> - return NULL;
> }
>
> #endif /* CONFIG_MEDIA_CONTROLLER */
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-02 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-26 7:44 [PATCH] media-device.h: fix compiler warning Hans Verkuil
2016-03-02 7:54 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox