From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lists.s-osg.org ([54.187.51.154]:57641 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754339AbcCBRcQ (ORCPT ); Wed, 2 Mar 2016 12:32:16 -0500 Subject: Re: [RFC] Representing hardware connections via MC To: Mauro Carvalho Chehab , Sakari Ailus References: <20160226091317.5a07c374@recife.lan> <20160302141643.GH11084@valkosipuli.retiisi.org.uk> <20160302124029.0e6cee85@recife.lan> <20160302130409.60df670f@recife.lan> Cc: LMML , Hans Verkuil , Javier Martinez Canillas , Laurent Pinchart , Shuah Khan From: Shuah Khan Message-ID: <56D7239E.6000904@osg.samsung.com> Date: Wed, 2 Mar 2016 10:32:14 -0700 MIME-Version: 1.0 In-Reply-To: <20160302130409.60df670f@recife.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 03/02/2016 09:04 AM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Mar 2016 12:40:29 -0300 > Mauro Carvalho Chehab escreveu: > >> After all the discussions, I guess "CONN" for connection is the best way >> to represent it. > > Better to put it on a patch. > > Please review. > > Regards, > Mauro > > [media] Better define MEDIA_ENT_F_CONN_* entities > > Putting concepts in a paper is hard, specially since different people > may interpret it in a different way. > > Make clear about the meaning of the MEDIA_ENT_F_CONN_* entities > > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/Documentation/DocBook/media/v4l/media-types.xml b/Documentation/DocBook/media/v4l/media-types.xml > index 5e3f20fdcf17..b036e6103949 100644 > --- a/Documentation/DocBook/media/v4l/media-types.xml > +++ b/Documentation/DocBook/media/v4l/media-types.xml > @@ -46,15 +46,26 @@ > > > MEDIA_ENT_F_CONN_RF > - Connector for a Radio Frequency (RF) signal. > + Entity representing the logical connection associated with a > + single Radio Frequency (RF) signal connector. It > + corresponds to the logical input or output associated > + with the RF signal. > > > MEDIA_ENT_F_CONN_SVIDEO > - Connector for a S-Video signal. > + Entity representing the logical connection assowiated > + with a sigle S-Video connector. Such entity should have > + two pads, one for the luminance signal(Y) and one > + for the chrominance signal (C). It corresponds to the > + logical input or output associated with S-Video Y and C > + signals. > > > MEDIA_ENT_F_CONN_COMPOSITE > - Connector for a RGB composite signal. > + Entity representing the logical connection for a composite > + signal. It corresponds to the logical input or output > + associated with the a single signal that carries both > + chrominance and luminance information (Y+C). > > > MEDIA_ENT_F_CAM_SENSOR Finally caught up with RFC discussion. Looks good to me. Thanks for the summary and the patch. Acked-by: Shuah Khan In general I agree with the direction to go with property API as it offers flexibility for future enhancements and allows drivers to care about only the properties they need to support. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978