Re: tw686x driver

[Hans Verkuil <hverkuil@xs4all.nl>]

On 03/03/16 15:22, Krzysztof Hałasa wrote:
> Hans Verkuil <hverkuil@xs4all.nl> writes:
> 
>> There is no point whatsoever in committing a driver and then replacing it
>> with another which has a different feature set. I'm not going to do
>> that.
> 
> Sure, that's why I haven't asked you to do it.
> Now there is no another driver, as Ezequiel stated - there is just one
> driver.
> 
> The point is clear, showing who exactly wrote what.
> 
>> One option that might be much more interesting is to add your driver to
>> staging with a TODO stating that the field support should be added to
>> the mainline driver.
> 
> Field mode is one thing. What's a bit more important is that Ezequiel's
> changes take away the SG DMA, and basically all DMA. The chip has to use
> DMA, but his driver then simply memcpy() all the data to userspace
> buffers. This doesn't work on low-power machines.
> 
> Staging is meant for completely different situation - for immature,
> incomplete code. It has nothing to do with the case.

It can be for anything that prevents it from being mainlined. It was (still is?)
used for mature android drivers, for example.

> 
>> I'm not sure if Mauro would go for it, but I think this is a fair option.
> 
> I don't expect the situation to be fair to me, anymore.
> 
> I also don't want to pursue the legal stuff, copyright laws etc.,
> but a quick glance at the COPYING file at the root of the kernel sources
> may be helpful:
> 
>> 2. You may modify your copy or copies of the Program or any portion
>> of it, thus forming a work based on the Program, and copy and
>> distribute such modifications or work under the terms of Section 1
>> above, provided that you also meet all of these conditions:
>>
>>     a) You must cause the modified files to carry prominent notices
>>     stating that you changed the files and the date of any change.
> 
> I don't even ask for that much - I only ask that the single set of
> changes from Ezequiel has this very information. This is BTW one of the
> reasons we switched to git.

Ezequiel, can you make a v4 and add a link to the original patch posted by
Krzysztof that you based your code on?

I think that takes care of the provenance.

Regards,

	Hans