From: Steve Longerbeam <steve_longerbeam@mentor.com>
To: Philippe De Muyter <phdm@macq.eu>, Hans Verkuil <hverkuil@xs4all.nl>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
<linux-media@vger.kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: i.mx6 camera interface (CSI) and mainline kernel
Date: Thu, 3 Mar 2016 09:45:08 -0800 [thread overview]
Message-ID: <56D87824.8000707@mentor.com> (raw)
In-Reply-To: <20160303083643.GA4303@frolo.macqel>
Hi Philippe,
On 03/03/2016 12:36 AM, Philippe De Muyter wrote:
>
> Just to be sure : do you mean https://github.com/slongerbeam/mediatree.git
> or something else ?
Sorry, yes I meant https://github.com/slongerbeam/mediatree.git.
>
>>> So far I have retested video capture with the SabreAuto/ADV7180 and
>>> the SabreSD/OV5640-mipi-csi2, and video capture is working fine on
>>> those platforms.
>>>
>>> There is also a mem2mem that should work fine, but haven't tested yet.
>>>
>>> I removed camera preview support. At Mentor Graphics we have made
>>> quite a few changes to ipu-v3 driver to allow camera preview to initialize
>>> and control an overlay display plane independently of imx-drm, by adding
>>> a subsystem independent ipu-plane sub-unit. Note we also have a video
>>> output overlay driver that also makes use of ipu-plane. But those changes are
>>> extensive and touch imx-drm as well as ipu-v3, so I am leaving camera preview
>>> and the output overlay driver out (in fact, camera preview is not of much
>>> utility so I probably won't bring it back in upstream version).
>>>
>>> The video capture driver is not quite ready for upstream review yet. It still:
>>>
>>> - uses the old cropping APIs but should move forward to selection APIs.
>>>
>>> - uses custom sensor subdev drivers for ADV7180 and OV564x. Still
>>> need to switch to upstream subdevs.
> Is it only a problem of those sensor drivers (which exact files ?) or
> is it a problem of the capture driver itself ?
The camera interface driver (drivers/staging/media/imx6/capture/mx6-camif.c)
is binding to these subdevs:
drivers/staging/media/imx6/capture/adv7180.c
drivers/staging/media/imx6/capture/ov5642.c
drivers/staging/media/imx6/capture/ov5640-mipi.c
But instead should use the subdevs under drivers/media/i2c, specifically:
drivers/media/i2c/adv7180.c (and adding whatever standard subdev features
the imx6 interface driver requires).
There is a drivers/media/i2c/soc_camera/ov5642.c, but there is no mipi-csi2
capable subdev for the ov5640 with the mipi-csi2 interface, so that would have
to be created.
> I must update a sensor driver I wrote for the intdev interface found
> in the freescale kernel, and I'd like to start from a working subdev
> example. Which driver should I choose as an example ?
There's lots of good examples under drivers/media/i2c/.
Steve
next prev parent reply other threads:[~2016-03-03 17:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 11:49 i.mx6 camera interface (CSI) and mainline kernel Philippe De Muyter
2016-02-23 14:12 ` Philippe De Muyter
2016-02-25 22:05 ` Laurent Pinchart
2016-03-03 2:02 ` Steve Longerbeam
2016-03-03 7:19 ` Hans Verkuil
2016-03-03 8:36 ` Philippe De Muyter
2016-03-03 17:45 ` Steve Longerbeam [this message]
2016-03-03 17:52 ` Philippe De Muyter
2016-03-07 16:19 ` Tim Harvey
2016-03-09 2:06 ` Steve Longerbeam
2016-03-09 22:44 ` Tim Harvey
2016-03-10 0:12 ` Steve Longerbeam
2016-03-10 7:30 ` Hans Verkuil
2016-03-14 14:55 ` Philippe De Muyter
2016-03-15 20:54 ` Tim Harvey
2016-06-02 13:29 ` Tim Harvey
2016-06-02 13:55 ` Hans Verkuil
2016-06-02 16:50 ` Steve Longerbeam
2016-06-06 16:48 ` Steve Longerbeam
2016-06-10 15:58 ` Jack Mitchell
2016-06-10 16:34 ` Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D87824.8000707@mentor.com \
--to=steve_longerbeam@mentor.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=phdm@macq.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox