From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM
Date: Fri, 04 Mar 2016 16:05:49 +0900 [thread overview]
Message-ID: <56D933CD.4070704@samsung.com> (raw)
In-Reply-To: <87y49yd8t6.fsf@gmail.com>
On 04.03.2016 16:03, Holger Schurig wrote:
> Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
>
>> + depends on HAS_IOMEM # For MFD_SYSCON
> ^^^^^^^^^^^^^^^^
>
> I think this comment is not necessary, it's also highly unusual. On
> other words: other patches like this don't add such comments.
>
> You can always use "git blame" to find out why some line has changed the
> way it changed ...
No problem, I can remove it. I thought it might be useful since this
dependency is not for the driver but for selected item.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-03-04 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 1:02 [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski
2016-03-04 7:03 ` Holger Schurig
2016-03-04 7:05 ` Krzysztof Kozlowski [this message]
2016-03-04 11:02 ` Sylwester Nawrocki
2016-03-05 4:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D933CD.4070704@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=arnd@arndb.de \
--cc=holgerschurig@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox