From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lists.s-osg.org ([54.187.51.154]:36721 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbcCGORx (ORCPT ); Mon, 7 Mar 2016 09:17:53 -0500 Subject: Re: [RFT 2/2] [media] exynos4-is: Add missing port parent of_node_put on error paths To: Krzysztof Kozlowski , Kyungmin Park , Sylwester Nawrocki , Mauro Carvalho Chehab , Kukjin Kim , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1453768906-28979-1-git-send-email-k.kozlowski@samsung.com> <1453768906-28979-2-git-send-email-k.kozlowski@samsung.com> From: Javier Martinez Canillas Message-ID: <56DD8D88.9020500@osg.samsung.com> Date: Mon, 7 Mar 2016 11:17:44 -0300 MIME-Version: 1.0 In-Reply-To: <1453768906-28979-2-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello Krzysztof, On 01/25/2016 09:41 PM, Krzysztof Kozlowski wrote: > In fimc_md_parse_port_node() remote port parent node is get with > of_graph_get_remote_port_parent() but it is not put on error path. > > Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for asynchronous subdevices registration") > Signed-off-by: Krzysztof Kozlowski > > --- > > Not tested on hardware, only built+static checkers. > --- > drivers/media/platform/exynos4-is/media-dev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c > index de0977479327..d2e564878e06 100644 > --- a/drivers/media/platform/exynos4-is/media-dev.c > +++ b/drivers/media/platform/exynos4-is/media-dev.c > @@ -385,8 +385,10 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd, > else > pd->fimc_bus_type = pd->sensor_bus_type; > > - if (WARN_ON(index >= ARRAY_SIZE(fmd->sensor))) > + if (WARN_ON(index >= ARRAY_SIZE(fmd->sensor))) { > + of_node_put(rem); > return -EINVAL; > + } > > fmd->sensor[index].asd.match_type = V4L2_ASYNC_MATCH_OF; > fmd->sensor[index].asd.match.of.node = rem; > Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America