From: Hans Verkuil <hverkuil@xs4all.nl>
To: tiffany lin <tiffany.lin@mediatek.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
daniel.thompson@linaro.org, Rob Herring <robh+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Daniel Kurtz <djkurtz@chromium.org>,
Pawel Osciak <posciak@chromium.org>,
Eddie Huang <eddie.huang@mediatek.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
PoChun.Lin@mediatek.com
Subject: Re: FW: [PATCH v5 0/8] Add MT8173 Video Encoder Driver and VPU Driver
Date: Mon, 14 Mar 2016 08:21:22 +0100 [thread overview]
Message-ID: <56E66672.9030307@xs4all.nl> (raw)
In-Reply-To: <1457939579.32502.10.camel@mtksdaap41>
On 03/14/2016 08:12 AM, tiffany lin wrote:
> Hi Hans,
>
> After change to use "v4l-utils.git master branch", "V4l2-compliance
> -d /dev/video1" fail on "fail: v4l2-test-buffers.cpp(555):
> check_0(crbufs.reserved, sizeof(crbufs.reserved))".
>
> Check the source code and found
>
> memset(&crbufs, 0xff, sizeof(crbufs)); -> crbufs to 0xff
> node->g_fmt(crbufs.format, i);
> crbufs.count = 0;
> crbufs.memory = m;
> fail_on_test(doioctl(node, VIDIOC_CREATE_BUFS, &crbufs));
> fail_on_test(check_0(crbufs.reserved, sizeof(crbufs.reserved)));
> fail_on_test(crbufs.index != q.g_buffers());
>
> crbufs is initialized to fill with 0xff and after VIDIOC_CREATE_BUFS,
> crbufs.reserved field should be 0x0. But v4l2_m2m_create_bufs and
> vb2_create_bufs do not process reserved filed.
> Do we really need to check reserved filed filled with 0x0? Or we need to
> change vb2_create_bufs to fix this issue?
The reserved field is zeroed in v4l_create_bufs() in v4l2-ioctl.c, so even before
vb2_create_bufs et al is called.
The fact that it is no longer zeroed afterwards suggests that someone is messing
with the reserved field.
You'll have to do a bit more digging, I'm afraid.
Regards,
Hans
next prev parent reply other threads:[~2016-03-14 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <D706F7FE148A8A429434F78C46336826048E7053@mtkmbs02n1>
2016-03-14 7:12 ` FW: [PATCH v5 0/8] Add MT8173 Video Encoder Driver and VPU Driver tiffany lin
2016-03-14 7:21 ` Hans Verkuil [this message]
2016-03-14 9:04 ` tiffany lin
2016-03-14 9:10 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E66672.9030307@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=PoChun.Lin@mediatek.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=eddie.huang@mediatek.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@osg.samsung.com \
--cc=posciak@chromium.org \
--cc=robh+dt@kernel.org \
--cc=tiffany.lin@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox