Re: [PATCHv13 01/17] dts: exynos4*: add HDMI CEC pin definition to pinctrl

Krzysztof Kozlowski
2016-03-21T00:22:55Z

On 19.03.2016 17:15, Hans Verkuil wrote:
> On 03/19/2016 03:50 AM, Krzysztof Kozlowski wrote:
>> On Fri, Mar 18, 2016 at 03:07:00PM +0100, Hans Verkuil wrote:
>>> From: Kamil Debski <kamil@wypas.org>
>>>
>>> Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and
>>> Exynos4x12 SoCs. These are required by the HDMI CEC device.
>>>
>>> Signed-off-by: Kamil Debski <kamil@wypas.org>
>>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
>>> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> ---
>>> arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 7 +++++++
>>> arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 7 +++++++
>>> 2 files changed, 14 insertions(+)
>>
>> Hi Hans,
>>
>> I see you have been carrying these three patches for a long time.
>> Initially I thought that there are some dependencies... but maybe there
>> are not?
>>
>> Can I take these Exynos DTS patches to samsung-soc?
>
> That would be very nice!

I'll apply them after merge window.

> BTW, it would be nice if someone from Samsung could try to improve the s5p
> CEC driver from this patch series.
>
> The problem is that it expects userspace to tell it the physical address,
> which is read from the EDID. But the HDMI driver in the kernel already knows
> this, so requiring userspace to handle this is not nice.
>
> Basically the CEC driver needs to know when a new EDID has been read and
> when the hotplug detect goes low (EDID has been lost).
>
> If someone who actually knows the HDMI code could provide me with a patch,
> then I can fix the CEC driver. I have an odroid to test with, so I can check
> the code.

Not quite my area of knowledge but I'll keep it in mind.

Best regards,
Krzysztof