From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:45729 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbcCYMoe (ORCPT ); Fri, 25 Mar 2016 08:44:34 -0400 Subject: Re: [PATCH v2 01/54] media: Add video processing entity functions To: Laurent Pinchart , linux-media@vger.kernel.org References: <1458902668-1141-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1458902668-1141-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Cc: linux-renesas-soc@vger.kernel.org From: Hans Verkuil Message-ID: <56F532AB.3000107@xs4all.nl> Date: Fri, 25 Mar 2016 13:44:27 +0100 MIME-Version: 1.0 In-Reply-To: <1458902668-1141-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 03/25/2016 11:43 AM, Laurent Pinchart wrote: > Add composer, format converter and scaler functions, as well as generic > video processing to be used when no other processing function is > applicable. > > Signed-off-by: Laurent Pinchart > --- > Documentation/DocBook/media/v4l/media-types.xml | 34 +++++++++++++++++++++++++ > include/uapi/linux/media.h | 8 ++++++ > 2 files changed, 42 insertions(+) > > diff --git a/Documentation/DocBook/media/v4l/media-types.xml b/Documentation/DocBook/media/v4l/media-types.xml > index 5e3f20fdcf17..a6e171e80bce 100644 > --- a/Documentation/DocBook/media/v4l/media-types.xml > +++ b/Documentation/DocBook/media/v4l/media-types.xml > @@ -121,6 +121,40 @@ > MEDIA_ENT_F_AUDIO_MIXER > Audio Mixer Function Entity. > > + > + MEDIA_ENT_F_PROC_VIDEO_GENERIC > + Generic video processing, when no other processing function > + is applicable. > + Does someone in this patch series use this one? If not, then just drop it. And if there is one, which patch is it? > + > + MEDIA_ENT_F_PROC_VIDEO_COMPOSER > + Video composer (blender). An entity capable of video > + composing must have at least two sink pads and one source > + pad, and composes input video frames onto output video > + frames. Composition can be performed using alpha blending, > + color keying, raster operations (ROP), stitching or any other > + mean. s/mean/means/ > + > + > + > + MEDIA_ENT_F_PROC_VIDEO_CONVERTER > + Video format converter. An entity capable of video format > + conversion must have at least one sink pad and one source > + pad, and convert the format of pixels received on its sink > + pad(s) to a different format output on its source pad(s). > + Does this cover a de-interlacer? > + > + > + MEDIA_ENT_F_PROC_VIDEO_SCALER > + Video scaler. An entity capable of video scaling must have > + at least one sink pad and one source pad, and scaling the > + video frame(s) received on its sink pad(s) to a different > + resolution output on its source pad(s). The range of > + supported scaling ratios is entity-specific and can differ > + between the horizontal and vertical directions. In particular > + scaling can be supported in one direction only. > + > + > > > Regards, Hans > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index df59edee25d1..884ec1cae09d 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -95,6 +95,14 @@ struct media_device_info { > #define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03003) > > /* > + * Processing entities > + */ > +#define MEDIA_ENT_F_PROC_VIDEO_GENERIC (MEDIA_ENT_F_BASE + 0x4001) > +#define MEDIA_ENT_F_PROC_VIDEO_COMPOSER (MEDIA_ENT_F_BASE + 0x4002) > +#define MEDIA_ENT_F_PROC_VIDEO_CONVERTER (MEDIA_ENT_F_BASE + 0x4003) > +#define MEDIA_ENT_F_PROC_VIDEO_SCALER (MEDIA_ENT_F_BASE + 0x4004) > + > +/* > * Connectors > */ > /* It is a responsibility of the entity drivers to add connectors and links */ >