From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B755375F95; Sat, 8 Aug 2026 09:55:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786182918; cv=none; b=MIil0r5rYc4B/tRyqcKo1INsdIKnIzegXzjGRT6rMfUMUdtgukw5X0fznsF7oNVDfbdgMSjnIWcgr4KMGC8SUMSu/njfScOG3kO+CRr26nH4Dyz+4+GMp5w6vVikhIKnJCRRTfdFqXRoii1WVihYjcQh7Puy28uhoLcTqbVsFcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786182918; c=relaxed/simple; bh=bl06rtKxALbcf+vOGUrYIerzUwYhvBEpiLzDSxNvzgo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VmTQX5Bebs1kV6eLChN9Gnv1CTL7J5ICv8VkePJgDoMMQP1+D0LuwbMkR5hN3WYjrwEtOxzHSqCZoiCRPOzMMUCNP9COp2k5zCVf+0A0t2uTON5Q/Mq1tYpfTmyxeUXd7iySXbhjXMnefaL0WqkRdOxGEdqedcRN8uhvi7O1CkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=db4a1lIy; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="db4a1lIy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 742D81F000E9; Sat, 8 Aug 2026 09:55:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786182915; bh=Ils5uLa957bCmy1VHewYvtg8uRsOXkPrMd404dlAez0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=db4a1lIy+MVSayrqQuNlxANJOADGLdSNGTxkDKOY5KBwa7wNpjVm8Ml9bEdmoYKNg R74eJPPNvWDYmmsfHtk3Zm38Js9lbUWgFldw8o359QQpwSfL2EDXvNJMMcejhKatLL 0VqZhec5S2zx+RZFn8u4RvMSGLkuNaLknTVdJ9Sqfrspvyrwhoy15LC2CnVbPMieVL 4910vWyf2/IEnVpxfiUPCRcLDcFdoQnOymH8TRCL48+WF9vXjMOetYY+0fFnMsq3ju AkyVCaNo7WK3ZN6E8vf6h6FnTAnOqA0zdfAxi7gkHQFMQlSkUIzOc2i6g2gCk77cqL 3oyAjhwD81SDQ== Message-ID: <56b3dfcf-b1ad-4192-8199-06c80cc5d124@kernel.org> Date: Sat, 8 Aug 2026 10:55:05 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/22] arm64: dts: qcom: hamoa: Reserve low IOVA range for Iris To: Vishnu Reddy , Rob Herring , Dmitry Baryshkov , Vikash Garodia Cc: Dikshita Agarwal , Mauro Carvalho Chehab , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Sakari Ailus , Abhinav Kumar , Stephan Gerhold , Bjorn Andersson , Stanimir Varbanov , Konrad Dybcio , Johan Hovold , Neil Armstrong , Loic Poulain , Jorge Ramirez-Ortiz , Mansur Alisha Shaik , Andy Gross , Rob Clark , Stephen Boyd , Yassine Oudjana , Pierre-Hugues Husson , Marc Gonzalez , cros-qcom-dts-watchers@chromium.org, Matthias Kaehlcke , Douglas Anderson , AngeloGioacchino Del Regno , Aniket Masule , Malathi Gottam , Rajendra Nayak , Jonathan Marek , Dikshita Agarwal , Renjiang Han , Krzysztof Kozlowski , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Mauro Carvalho Chehab , Konrad Dybcio , Krzysztof Kozlowski , Daniel J Blueman , stable@vger.kernel.org References: <20260807-iris_iova_600mb_fix-v1-0-3996f67e33f9@oss.qualcomm.com> <20260807-iris_iova_600mb_fix-v1-4-3996f67e33f9@oss.qualcomm.com> <20260807162405.GA896590-robh@kernel.org> <6ee7f32e-eb6c-e264-6f0d-541555f8fd62@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-GB Autocrypt: addr=bod@kernel.org; keydata= xsFNBGRJNSgBEADD7Vm2ZFa+v+JGJ2QYTJqQAkqis/uOHkhdFNXqpBarVBd47QU/DMNU5Rxg jedMQEmHoeDbJ6UOpjbrUQ63c5sgG1JbroHJJctwsEI75OOlekMuebEbjIJBLfgENGwPBMHv piv5TgCWr0VgYaXfp2eh2LINFywzqj823HiDPibQAXDrjzvF1ogksi/6cQZs8d4if8YQkLOr YISFouG+eR0nN1I7mUfIddXOWu6lJeTyqbWVurv58k2ekIXKaOC9ixLHFbcfYV0hOgRaTwQC B8CYF9nfqZla19iItfsN9QxN+ZdQjcRoYipp6HPCMfJlKH7GfaFcW93LKc4DKJ2lVL+pg/OQ lythZbjRPY492NG9kZ65aYstCs90uhMUEVVPuGUw7wBEku+6IEwZfrbMVKeWzLlPyM4Hv9hM 8ktxSmxWsPTPqpBC8eyeAQLalMELAyVcZlkaCtEcbj7w4l/JkYz+4l37obG8ZD+B34udBUUz MsAJ8foDFrBh2MOFA3hxD6G90D23mmWsri7pnKA2tZs92aQX7Ee+FbCyg6g5ln62Sq83ZDbf 53DdBs55EVpBadeInWmXhzCHPQx06H+CwTEjShTYIaMmBfrewvYUDKvFTC5iKQhAEUgt6i94 JsbG7NoeqcxkUMcBOEUQ3uCQG1D70ugspgXc0wd3Rimiq6535wARAQABzSFCcnlhbiBPJ0Rv bm9naHVlIDxib2RAa2VybmVsLm9yZz7CwZEEEwEIADsWIQTmk/sqq6Nt4Rerb7QicTuzoY3I OgUCZ+R+mwIbAwULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgAAKCRAicTuzoY3IOimUD/94 BwVEJX31JRe2sxbB/e1w2p8x1bxvTw5AeIzpV3ox7coJg1bSU2mnGuj1V4o0Yxf/3zmcJzCN VfVjwRF8Ii3GnC7uUXk2t+87piQfKTyJAYQABhZUKgoVJbjJq/S+C3XCKIyBA+EiezoUsgsA jTzwU+FzV7zVWIXFPJNtBERLwboE9w9U3KjAExOa1kSY8eLrsg6kOwlOHWy5UsQqYOjrS96M mzm2xuc1+RCjrndAyYhCnrOKvJ67HsPnBeJCjw7ImGD/U1GchwYbX8o3DO3JNHm3qfC86ZqX 2sCouENg4OzgPTtLKUrueM6xsu6KMM7gj17vxsiR3KQEoJnnMB8D1xtBofN3mFZE0wD9M24m 8yGunZbtntMCUHzIrlJgAPwKWKuGOYtA8UgMTFkccnUJtQrg9KotKtEF/FuftG9zLG9XEkt4 5ZdNgbSoLWgelu3T47mbOJ8LHhiLaCWP7yrovtVAvLUQ1BsiA42u8ECrFCFvQj9nrejE/ICv kP+uqcKtdDvP9HrIGycF1WZyfZLp0RvopKW92FLvI4I1QFWJ+wenk6+LGyJ5bzlrWzevjxmf nHcXE6sJBHrE7eijlbbImDAi3uLYN8Nd9Dm11IDAy4GAIQxSiQn0yblDhPiyGtchy80EVkCm g9k17Wol+2E2mC4DKgVdCkyUtTRSLgsJCs7BTQRkSTUoARAAuTnmWHBS6izRcEE93ajpzI7h dgQO4U3IRvOEsvIKR5NGcNEs0ngGebwsZ/lVULjN4vYU0LleqVhPBidNXUoZCN3A0F0Z2Ov8 NZdef+2EhQPBVWxFO7JBzhe8Z3ALj+wFtlg8akJjBzU56azW/iJzAobqHVrudzKoO2b1/CMg VbiAQ+RXjgfN5kY/HqYDU7mw+hXuUV9PbtX1L8xqQQac95oM9rHzKHHpiVwxTeJnGQsa+THi Kze+YET3rCoGHMvOQEJhdrucTv5FpAakKdkOFNel9FFckLRKEuWgCzhpFsjQ7xbirQgFUxG9 vlk1+q4hMRGNyEqoD6svYEeqbiUSd0oPUJeioiC3rNMRCNHLVrfZ2J6SCPkxfda08uzSdDQU 1/YPjOh8ZtQDMu7WctZ3XO288Z1gyBR49V7fbFs2w4sQxG+h/enlxqP7fdw1mjUlZjU5huCJ ielS0oEaIpmUpkugli7x4WhwLnhK2EbSoz7nLBC0y+ALUOdMlz/Y1l9xRt+bkDhpmf4O4IcI MxgZ0QMLq8rHDkGaEbsgZZHQPS58T0XE3IP30Q9SNxsruCMXtd2hYtBssf/wohc6JVsTtMg2 VYTPDPIFNZFSXupEJB7jlqpDWJ8ooJfJRLBatbjT5+mVQaMYB7Hs/t+zWYWaJKHyc8O6WLEC NUV5Tdt5EkkAEQEAAcLBdgQYAQoAIBYhBOaT+yqro23hF6tvtCJxO7Ohjcg6BQJkSTUoAhsM AAoJECJxO7Ohjcg6LuIQALnXt36OUuK43wqw6UYt0cnN6EbUqJHApAF5eNFn0jCCB2XELjSz JKJwuNAweowBdabiBniJ+501WIW+ewEsz1uby5fUQjZuCEsIkuaIluyfUFPb73qrQyAGuusd 7teA4WT+/jUku9g7lX5sVoRCrKQPkd16f6Bzfztyqyjcn43/X5yQI+wlboQ6HuKe/3I3yiOx OgmCHzOawpC9PvhEcKj79RLM3Zz5Ts5AuHpRX70Jz8Be76LwVFLp5Msx3S24ZTU1lBo2uiJ3 xSkay2lTpyVWRPx9vgcwzxGguOPJQJwsQeLb7wpoJMPpD3ERoaRii7Q7hvmxklpZjhKYWB3d t6nQ497Ek9loCrp3MIjRCSDN5xEGffiHks9yTeGMUQwO4tX8RE04uOJPkUY7uCFzFqN6/qey X3oFfPgkULMdiHofPAL1OskZSTzGPSfTYRE46NCJw8yoZBQ/oOyWeqaUQbK0wmW/g81wm8p7 LKSGEglMpiX07M1AotgvylN5C8fjbouoK+/RAMsXkk8jba6rPfuuXPaDjCyyKn6zSVHETnHW 3AJbgVY50T8STpnxayBQvWbCvu+6NOEjXCbyaOJig+5l0zlGN9XHjdANXC5HnwmyaGRL9YDq Jh2nVXVJDincOdQRdKcJjYLqaOAoWrYWSDi1iZGspHBTDrnOvfMQzzHY In-Reply-To: <6ee7f32e-eb6c-e264-6f0d-541555f8fd62@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08/08/2026 05:37, Vishnu Reddy wrote: > > On 8/7/2026 9:54 PM, Rob Herring wrote: >> On Fri, Aug 07, 2026 at 12:03:50PM +0300, Dmitry Baryshkov wrote: >>> On Fri, Aug 07, 2026 at 01:54:48PM +0530, Vikash Garodia wrote: >>>> From: Daniel J Blueman >>>> >>>> On X1-family hamoa platforms, the Iris VPU reserves IOVA addresses >>>> below 0x25800000 (600MB), primarily for secure non-pixel buffers. DMA >>>> into that range, from any other stream id would triggers unhandled SMMU >>>> page faults that cause spontaneous device reboots. This is readily >>>> reproduced with one or more browser tabs driving multiple concurrent >>>> video decode streams. >>>> >>>> Add a reserved-memory IOVA reservation node covering [0, 0x25800000] >>>> and reference it from the Iris node so the IOMMU layer keeps DMA >>>> allocations above that boundary. >>>> >>>> Link: https://github.com/qualcomm-linux/kernel-topics/issues/1157#issuecomment-4458933574 >>>> Fixes: 9065340ac04d ("arm64: dts: qcom: x1e80100: Add IRIS video codec") >>>> Cc: stable@vger.kernel.org >>>> Signed-off-by: Daniel J Blueman >>>> Signed-off-by: Vikash Garodia >>>> --- >>>> arch/arm64/boot/dts/qcom/hamoa.dtsi | 13 ++++++++++++- >>>> 1 file changed, 12 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi >>>> index 8a96ea1bdb9c4c409b2af997680d8c13fed0643e..87f424765d513c97b06303bceb75ca9f176d2ace 100644 >>>> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi >>>> @@ -666,6 +666,17 @@ smem_mem: smem@ffe00000 { >>>> hwlocks = <&tcsr_mutex 3>; >>>> no-map; >>>> }; >>>> + >>>> + /* >>>> + * The Iris VPU reserves IOVA below 0x25800000 (600MB), >>>> + * primarily for non-pixel buffers using different Stream IDs. >>>> + * DMA into that range triggers unhandled SMMU faults and >>>> + * spontaneous reboots, so reserve it to keep IOMMU >>>> + * allocations above this boundary. >>>> + */ >>>> + iris_iova: iris-iova { >>>> + iommu-addresses = <&iris 0x0 0x0 0x0 0x25800000>; >>>> + }; >>>> }; >>>> >>>> qup_opp_table_100mhz: opp-table-qup100mhz { >>>> @@ -5439,7 +5450,7 @@ &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, >>>> interconnect-names = "cpu-cfg", >>>> "video-mem"; >>>> >>>> - memory-region = <&video_mem>; >>>> + memory-region = <&video_mem>, <&iris_iova>; >>> I don't like the idea of this series, because it _again_ doesn't tell us >>> the truth about the hardware. This typicall ends up with bigger problems >>> later on, when it starts to affect other bits and pieces. >>> >>> I don't want to NAK it, but I'd strongly ask to reconsider it. >> I think this is an abuse of /reserved-memory. reserved-memory is >> reserved *physical* memory. Reserved IOVA is a property on top of that. >> I'm surprised this passes validation. If it does, I may go fix that. > > As per the reserved-memory.yaml schema document, the iommu-addresses > property for IOVA reservation into /reserved-memory is allowed — it's > documented for IOVA carveout reservations: > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/reserved-memory/reserved-memory.yaml#L56 I think that is an entirely reasonable reading of the text Quote: "If no "reg" property is specified, the "iommu-addresses" property defines carveout regions in the IOVA space for the given device. This can be useful if a certain memory region should not be mapped through the IOMMU." Which is exactly what this series does. Excludes a specific IOVA range from being allocated for this device. --- bod