Re: [PATCH v2 47/67] media: platform: rename sunxi/ to allwinner/

Laurent Pinchart
2022-03-15T06:54:51Z

Hi Mauro,

On Tue, Mar 15, 2022 at 06:40:05AM +0100, Mauro Carvalho Chehab wrote:
> Em Mon, 14 Mar 2022 18:22:20 +0100 Jernej Škrabec escreveu:
>
> > Dne ponedeljek, 14. marec 2022 ob 17:34:42 CET je Mauro Carvalho Chehab
> > napisal(a):
> > > As the end goal is to have platform drivers split by vendor,
> > > rename sunxi/ to allwinner/.
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> >
> > I would rather not do that. Everything related to Allwinner is called sunxi,
> > albeit there are a few outliers. This is similar to Amlogic/meson situation.
>
> The rationale of having one directory per manufacturer is that, if drivers
> for newer platforms with different names from the same manufacturers are
> added, those will still fit under allwinner/ and amlogic/.
>
> The Kconfig names for sunxi and meson didn't change, nor the driver's name.
> Also, the directories under allwinner preserve sun<x>i name on them:
>
> drivers/media/platform/allwinner/
> ├── sun4i-csi
> ├── sun6i-csi
> ├── sun8i-di
> └── sun8i-rotate
>
> and so the directory under amlogic/:
>
> drivers/media/platform/amlogic/
> └── meson-ge2d
>
> Now, if Allinner decides to release a new platforms named after another star,
> let's say, "Vega" and "Rigel", it would be just a matter of adding
> "vega/" and "rigel/" directories under allwinner. No need to touch
> media/platform/Kconfig and media/platform/Makefile. Everything will happen
> on much more smaller vendor-specific Kconfig/Makefile.

But the day Allwinner changes its name to Noloser, we'll have a similar
problem. Thnk about Freescale vs. NXP, or Altera bought by Intel. No
naming scheme is totally future-proof. If the accepted standard through
the kernel is to use sunxi to refer to Allwinner SoCs, I don't think
it's a bit idea to go with that.

> See for instance, TI. We had initially a single driver, and everywhere it
> was called "omap", which was had gained different versions (omap2, omap3,
> ...). Then, TI decided to use other names for newer IP (davinci, am437x),
> and now the current development is at cal and vpe.
>
> If we had placed a ti/ directory by the time omap were added (and the
> same for the other vendors), we would have avoided the need of this
> reorg.

--
Regards,

Laurent Pinchart