Re: [PATCH] uvcvideo: Add bayer 16-bit format patterns

Laurent Pinchart
2016-11-15T19:07:51Z

Hi Sakari,

On Tuesday 15 Nov 2016 19:04:02 Sakari Ailus wrote:
> On Tue, Nov 15, 2016 at 04:44:04PM +0200, Laurent Pinchart wrote:
> > Hi Sakari,
>
> ...
>
> >> +Description
> >> +===========
> >> +
> >> +These four pixel formats are raw sRGB / Bayer formats with 16 bits per
> >> +sample. Each sample is stored in a 16-bit word. Each n-pixel row
> >> contains
> >> +n/2 green samples and n/2 blue or red samples, with alternating red and
> >> blue
> >> +rows. Bytes are stored in memory in little endian order. They are
> >> +conventionally described as GRGR... BGBG..., RGRG... GBGB..., etc.
> >> Below is
> >> +an example of one of these formats:
> >
> > To make it clearer, how about telling which format that is ?
>
> I don't object the change as such, but the text is the same than on other
> bayer formats as well. The fix should not be done on this one only.
>
> I propose to handle that separately if that's ok for you.

I'm fine with that, can you submit a patch ? :-)

--
Regards,

Laurent Pinchart